From: Stefano Brivio <sbrivio@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf-next] netfilter: nft_set_pipapo_avx2: remove redundant loop in lookup_slow
Date: Sat, 21 Mar 2026 15:25:20 +0100 (CET) [thread overview]
Message-ID: <20260321152520.041dedb8@elisabeth> (raw)
In-Reply-To: <20260318134217.1596-1-fw@strlen.de>
On Wed, 18 Mar 2026 14:42:12 +0100
Florian Westphal <fw@strlen.de> wrote:
> nft_pipapo_avx2_lookup_slow will never be used in reality, because the
> common sizes are handled by avx2 optimized versions.
>
> However, nft_pipapo_avx2_lookup_slow loops over the data just like the
> avx2 functions. BUT _slow doesn't need to do that:
> pipapo_and_field_buckets_() + pipapo_refill() already handle
> everyhing for us.
Ah, right, indeed.
> All other iterations boild down to 'x = x & x': Remove the loop.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2026-03-21 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 13:42 [PATCH nf-next] netfilter: nft_set_pipapo_avx2: remove redundant loop in lookup_slow Florian Westphal
2026-03-21 14:25 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321152520.041dedb8@elisabeth \
--to=sbrivio@redhat.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox