From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>, Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 0/7] netfilter: switch ipset to rhashtable
Date: Thu, 6 Aug 2026 12:19:40 +0200 [thread overview]
Message-ID: <20260806101947.2802-1-fw@strlen.de> (raw)
1) Replace memory allocation in ipset delete operations with in-place
substitution. Move empty CIDR ranges to the end of the array.
This addresses LLM findings of a patch from the rhashtable preparation
series.
2) Fix list_type ext_size memory accounting on set flush. As-is,
flush sets the value to 0, but call_rcu() destructor can subtract again.
Addresses drive-by LLM report.
3) Add rhashtable boilerplate stubs to netfilter ipset. Implement rhashtable
initialization and destruction routines.
4) Add rhltable boilerplate stubs to netfilter ipset. Prepare transitioning
certain hash sets from rhashtable to rhltable. Was not part of RFC,
needed for the 'net,iface.t' set type.
5) Replace ipset hash tables with rhashtable.
This change will splat on debug kernels, fix is queued as
'rhashtable: fix false-positive lockdep splat on rhltable destruction'
in herbert/crypto-2.6.git.
6) Restore forceadd support to ipset rhashtable via random element
eviction.
7) Include dynamic CIDR storage memory size in userspace reports.
Another LLM finding during review of initial preparation patches.
Florian Westphal (7):
netfilter: ipset: remove need to allocate memory on delete operations
netfilter: ipset: let destroy callbacks adjust ext mem size
netfilter: ipset: add rhashtable boilerplate stubs
netfilter: ipset: add rhltable boilerplate stubs
netfilter: ipset: replace internal hash table with rhashtable
netfilter: ipset: re-add forceadd support for rhashtable
netfilter: ipset: also report mem size for cidr storage to userspace
net/netfilter/ipset/ip_set_bitmap_gen.h | 2 +-
net/netfilter/ipset/ip_set_hash_gen.h | 1716 ++++++++----------
net/netfilter/ipset/ip_set_hash_netiface.c | 25 +-
net/netfilter/ipset/ip_set_hash_netportnet.c | 1 -
net/netfilter/ipset/ip_set_list_set.c | 3 +-
5 files changed, 734 insertions(+), 1013 deletions(-)
--
2.54.0
next reply other threads:[~2026-08-06 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 10:19 Florian Westphal [this message]
2026-08-06 10:19 ` [PATCH nf 1/7] netfilter: ipset: remove need to allocate memory on delete operations Florian Westphal
2026-08-09 12:56 ` Jozsef Kadlecsik
2026-08-09 14:14 ` Florian Westphal
2026-08-06 10:19 ` [PATCH nf 2/7] netfilter: ipset: let destroy callbacks adjust ext mem size Florian Westphal
2026-08-06 10:19 ` [PATCH nf 3/7] netfilter: ipset: add rhashtable boilerplate stubs Florian Westphal
2026-08-06 10:19 ` [PATCH nf 4/7] netfilter: ipset: add rhltable " Florian Westphal
2026-08-06 10:19 ` [PATCH nf 5/7] netfilter: ipset: replace internal hash table with rhashtable Florian Westphal
2026-08-06 10:19 ` [PATCH nf 6/7] netfilter: ipset: re-add forceadd support for rhashtable Florian Westphal
2026-08-06 10:19 ` [PATCH nf 7/7] netfilter: ipset: also report mem size for cidr storage to userspace Florian Westphal
2026-08-06 15:22 ` [syzbot ci] Re: netfilter: switch ipset to rhashtable syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806101947.2802-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox