From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4170C52F28F for ; Tue, 22 Sep 2026 08:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790066818; cv=none; b=gKveizgYi+8FFyy6rMk6ngpGFDrAjMt7y1WncOnGfeyjJc2xcBUzYs6Sp7ztqEfqHT5ngQua/5eCoxpQ4Jn6raN5zTKzD/lgTqp0Jd/oJaOYYlrID7vo24ioRezOrz6O+c1VKJBLJViUohkY3MC8Uw4j1dydLGnWBZAJ5zJBcJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790066818; c=relaxed/simple; bh=hEj5nL9MRpMH+JX12YZNspzZFd1+3Fuf+CZGgePMxM4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gM5WtwUk3M7TrubweHF/xQnThN4UYAla/oGRBmSUKy6voiWj4klKWMyqu+3tkK8sXj/5i5TuCowbSzhlHpw4Xn4UfHbZ02+P/7dlZIm3UGnV7e1GFQDDY8Pae+coJznRsTi4kPtlzWqEv325gdMp357r1/rGbM6VOlR9kOS5WNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PPtBm7O5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WaYJ8M0W; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PPtBm7O5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WaYJ8M0W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790066816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C95bRAv5IkFCsxK5LjzncGYLGpBLHTNK6JTZFhyWW0M=; b=PPtBm7O5J9SD12HP/tRvqumwwKrb2GaMHrA1THD7uzs1uzeGdvT+YtVVEomkLiG+dmdnUl jMQ6cThAO/9QcQBExBWKDP0pkDcUHbQqp0Hx6aFCf7mea7dtzs7QripU8kfQdra1V5pEjx tDxHqO04AyNKNOpa7C07D8vut8NCW+o= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-K7Beim7QMk2K3Wdoy44Rww-1; Tue, 22 Sep 2026 04:46:54 -0400 X-MC-Unique: K7Beim7QMk2K3Wdoy44Rww-1 X-Mimecast-MFC-AGG-ID: K7Beim7QMk2K3Wdoy44Rww_1790066813 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49e7631c43aso50743635e9.3 for ; Tue, 22 Sep 2026 01:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790066813; x=1790671613; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=C95bRAv5IkFCsxK5LjzncGYLGpBLHTNK6JTZFhyWW0M=; b=WaYJ8M0WDXY41t6aJdV7dAtLD/WG9BCa/2mVdYHEDhRiXod0jioeiS2VtDV6Az20T7 +Gr5LExcSy4Ohg55uWipz3cTnR3X5yZ5Vrt3O1jcfjIJXGVmEb62WZWwUXYJfrNtTYV3 gjCLuime50/prA+2ewWPzEGdksjxsuIW2XXn+WOC49hXygfCGlALNjwZD+au/Rmiarrz a8hNui9wBUadUJBh10cz5P/IAhq1F8jYrrl8p64nuynZB/YFqgf+HF+ASUJIMXfAu9Tq 6iWjtEM/9Wp196S8wQxONv3r6kNIo0cZfqqbyuIVxvcyXASjjndyrHKkyhslSraLunjy aWJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790066813; x=1790671613; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C95bRAv5IkFCsxK5LjzncGYLGpBLHTNK6JTZFhyWW0M=; b=VWgd9N8wIBmfwm7QPMyto85lLj9I2hO/hJyW594QHRBIDVczf6n4JAHrdsWvDGUSnq b+in996mEYUoPMNyIjDHoe8T7erwqDM7fnPffaeFdZOtqhQ++TXUtXto6zifN8/5veVp Z577cTiOeR7fmSolW4gB8xtytnWxmntrR9zp1zot8ua1RW7fMyD/OUu/Sdt8GpynsPH1 pLkHz4H5j4s/rfUxw+4JK97SQyioD1H+jatDCZLH533kEv/IyumNGs/WVqHQm4rd6tu3 ZshzBPsYcD7G+HIU3MAHSL21k1nUGswMtTwjR/FlCYzCk+CamJ1yygFzlI9Tb/adhx5X pF6A== X-Forwarded-Encrypted: i=1; AKwUvByMUEvR1MRrq/Y92PIRU3eYzR75nrv/hwK3RO7wNVAR/RS0aek95mJG3A67IG/TiG398WdJCQFVCZIhLmZ12kA=@vger.kernel.org X-Gm-Message-State: AFuF++n29+5OWyK9KwQIoNSxvIC9cs3s18YbKrxDWTIu2K/7dT6oHg1n DqLMtBYtFgLIwxICFlg4/NukUw9iUM9NibnW2x+MvBCtrTEw9vv5mBvgriaKEgPAap6H89ek9Vn I8Le4jYCWvBgBi+q74IFw1+Xcnkk0qMGUYL6GCpQE7Uwa8rKNhWTPSemWYzOLDhsAAMVb6w== X-Gm-Gg: AYBFou0C3590WDBtOlH3W5q2ZuxE+0b27vb+PIybDngnQ8Qry3vGixM++rskFDijN64 DGUFhsn23tO6mp3c6h2kgGMhJiYjedWZlSCR/iLwG8sGOiGo0O6ba5suawjxTU7qlMqIwojTs2q vGObskakqKbNjIxraTJk8kxoB0oW0rXmJfHLGbVLY6PuFvbH3CVtitmExjeaOTn+WQGVf/X8TFl hKiW3wGFZdDNWz5bQrZRUVwYVLWcKP/80Hk37WGKIbN7ezvBQizt0G6X8kYPy48NlxcOjx0VKIn m8o224tR1rMsUI+0p2Wt35hiRcFmmz26TpUFda7tVZw2DRcOMK9GhBVsd5aPcamYDLVT1NpoaFh 3+YZwQKGrN0+r24rL3XAQ8b4= X-Received: by 2002:a05:600c:19cd:b0:499:7a15:fcec with SMTP id 5b1f17b1804b1-49fc5695861mr190094885e9.13.1790066813178; Tue, 22 Sep 2026 01:46:53 -0700 (PDT) X-Received: by 2002:a05:600c:19cd:b0:499:7a15:fcec with SMTP id 5b1f17b1804b1-49fc5695861mr190094445e9.13.1790066812661; Tue, 22 Sep 2026 01:46:52 -0700 (PDT) Received: from redhat.com (IGLD-80-230-79-236.inter.net.il. [80.230.79.236]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fd8ccd185sm65246905e9.8.2026.09.22.01.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 01:46:52 -0700 (PDT) Date: Tue, 22 Sep 2026 04:46:47 -0400 From: "Michael S. Tsirkin" To: Johannes Berg Cc: Paulos Yibelo , netdev@vger.kernel.org, richard@nod.at, anton.ivanov@cambridgegreys.com, willemdebruijn.kernel@gmail.com, jasowangio@gmail.com, eperezma@redhat.com, xuanzhuo@linux.alibaba.com, andrew+netdev@lunn.ch, pablo@netfilter.org, fw@strlen.de, phil@nwl.cc, razor@blackwall.org, idosch@nvidia.com, dsahern@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-um@lists.infradead.org, virtualization@lists.linux.dev, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v6 1/2] net: validate virtio checksum start after network header Message-ID: <20260922044627-mutt-send-email-mst@kernel.org> References: <20260922030310.8684-1-habte.yibelo@gmail.com> <20260922030310.8684-2-habte.yibelo@gmail.com> <20260922005353-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 22, 2026 at 07:56:23AM +0200, Johannes Berg wrote: > On Tue, 2026-09-22 at 01:14 -0400, Michael S. Tsirkin wrote: > > > > > > > > +/* > > > + * Return the L3 offset and protocol of an Ethernet frame starting at skb->data. > > > + * The offset is unused without NEEDS_CSUM, so avoid parsing and return zero. > > > + */ > > > > for networking code multiline comments: > > > > /* always > > * look like this > > */ > > > > /* > > * never > > * like this > > */ > > This, for the record, is't really true any more - we dropped the special > rule a few years ago. > > johannes Oh good to know. thanks!