netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Haller <thaller@redhat.com>
To: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft v2 0/3] tests/shell: allow running tests as non-root
Date: Sun, 03 Sep 2023 19:01:32 +0200	[thread overview]
Message-ID: <24a5a98be95369174e8dbfdddd1d6c9dcc0905f6.camel@redhat.com> (raw)
In-Reply-To: <20230901150916.183949-1-thaller@redhat.com>

On Fri, 2023-09-01 at 17:05 +0200, Thomas Haller wrote:
> Changes to v2:
> 
> - new patch: rework the parsing of command line options
> - new patch: add a "--list-tests" option to show the found tests
> - call "unshare" for each test individually.
> - drop NFT_TEST_ROOTLESS environment variable. You no longer have to
>   opt-in to run rootless. However, if any tests fail and we ran
>   rootless, then an info is printed at the end.
> - the environment variables NFT_TEST_HAVE_REALROOT and
>   NFT_TEST_NO_UNSHARE can still be set to configure the script.
>   Those are now also configurable via command line options.
>   Usually you would not have to set them.
> 
> Thomas Haller (3):
>   tests/shell: rework command line parsing in "run-tests.sh"
>   tests/shell: rework finding tests and add "--list-tests" option
>   tests/shell: run each test in separate namespace and allow rootless
> 
>  tests/shell/run-tests.sh | 191 +++++++++++++++++++++++++++----------
> --
>  1 file changed, 132 insertions(+), 59 deletions(-)
> 

v2 has still several problems. I got too impatient before sending the
patches.

v3 will fix those, and add several further improvements... hold on.


Thomas


      parent reply	other threads:[~2023-09-03 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01 15:05 [PATCH nft v2 0/3] tests/shell: allow running tests as non-root Thomas Haller
2023-09-01 15:05 ` [PATCH nft v2 1/3] tests/shell: rework command line parsing in "run-tests.sh" Thomas Haller
2023-09-01 15:05 ` [PATCH nft v2 2/3] tests/shell: rework finding tests and add "--list-tests" option Thomas Haller
2023-09-01 15:05 ` [PATCH nft v2 3/3] tests/shell: run each test in separate namespace and allow rootless Thomas Haller
2023-09-04  8:45   ` Florian Westphal
2023-09-03 17:01 ` Thomas Haller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24a5a98be95369174e8dbfdddd1d6c9dcc0905f6.camel@redhat.com \
    --to=thaller@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).