* [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h
@ 2023-09-27 6:13 chenguohua
2023-10-08 12:29 ` Florian Westphal
0 siblings, 1 reply; 2+ messages in thread
From: chenguohua @ 2023-09-27 6:13 UTC (permalink / raw)
To: pablo, kadlec, fw; +Cc: netfilter-devel, coreteam, linux-kernel
Fix the following errors reported by checkpatch:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
---
include/linux/netfilter/nf_conntrack_h323_asn1.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netfilter/nf_conntrack_h323_asn1.h b/include/linux/netfilter/nf_conntrack_h323_asn1.h
index bd6797f823b2..514da3e8c8a8 100644
--- a/include/linux/netfilter/nf_conntrack_h323_asn1.h
+++ b/include/linux/netfilter/nf_conntrack_h323_asn1.h
@@ -88,8 +88,8 @@ typedef struct {
* Decode Functions
****************************************************************************/
-int DecodeRasMessage(unsigned char *buf, size_t sz, RasMessage * ras);
-int DecodeQ931(unsigned char *buf, size_t sz, Q931 * q931);
+int DecodeRasMessage(unsigned char *buf, size_t sz, RasMessage *ras);
+int DecodeQ931(unsigned char *buf, size_t sz, Q931 *q931);
int DecodeMultimediaSystemControlMessage(unsigned char *buf, size_t sz,
MultimediaSystemControlMessage *
mscm);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h
2023-09-27 6:13 [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h chenguohua
@ 2023-10-08 12:29 ` Florian Westphal
0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2023-10-08 12:29 UTC (permalink / raw)
To: chenguohua; +Cc: pablo, kadlec, fw, netfilter-devel, coreteam, linux-kernel
chenguohua@jari.cn <chenguohua@jari.cn> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo * bar" should be "foo *bar"
Running "checkpatch -f" for all nf related files results
in a myriad of "warnings". I don't think there is a good
reason to "fix" them.
checkpatch is good for new patch submissions, but I
do not think its worth it to adjust all the existing files.
Sorry.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-08 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 6:13 [PATCH] netfilter: Clean up errors in nf_conntrack_h323_asn1.h chenguohua
2023-10-08 12:29 ` Florian Westphal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).