From: James King <t.james.king@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: Targets with "mangle" table limiting (Was: Re: Troubles with MARK target in 2.6.28)
Date: Sat, 17 Jan 2009 23:32:12 -0800 [thread overview]
Message-ID: <38bcb3ec0901172332y55640cabx86d1200f68f11246@mail.gmail.com> (raw)
In-Reply-To: <49703F7F.8040603@trash.net>
On Fri, Jan 16, 2009 at 12:04 AM, Patrick McHardy <kaber@trash.net> wrote:
>>> Are there perhaps other targets besides MARK whose table restriction
>>> should be relaxed?
>>
>> Could TOS/DSCP just call ip_route_me_harder() directly when necessary
>> instead of relying on the mangle hook to do so? This would allow it
>> to be used everywhere.
>
> That doesn't seem like a good idea. Rerouting should be an optional
> feature, available in the (misnamed) mangle table. There might be
> completely different reasons for changing DSCP. So making them available
> in other tables yes, making them responsible for rerouting no.
True, however, I was mainly thinking about the confusion that might
result if it becomes available in all tables. For instance, someone
who relies on reroute after DSCP change (which is implicit on output)
accidentally omits the table specifier, causing the rule to default to
filter. Or if mangle can be made entirely superfluous by
unrestricting all other targets, is there any sense in keeping it
around for a single target? Maybe adding a new revision that allows
for explicit rerouting after the target action (such as
--set-dscp-and-reroute) might address this?
next prev parent reply other threads:[~2009-01-18 7:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86617ABF8F494F2A940C18251E3DC8D0@Hakkenden>
2009-01-12 6:19 ` Troubles with MARK target in 2.6.28 Patrick McHardy
2009-01-12 7:08 ` Patrick McHardy
2009-01-12 7:15 ` Jan Engelhardt
2009-01-12 7:18 ` Patrick McHardy
2009-01-14 5:39 ` Jan Engelhardt
2009-01-15 8:06 ` Targets with "mangle" table limiting (Was: Re: Troubles with MARK target in 2.6.28) Jan Engelhardt
2009-01-15 12:08 ` James King
2009-01-15 13:47 ` Patrick McHardy
2009-01-15 16:44 ` Jan Engelhardt
2009-01-15 22:38 ` James King
2009-01-16 8:04 ` Patrick McHardy
2009-01-18 7:32 ` James King [this message]
2009-01-16 7:33 ` Patrick McHardy
2009-01-16 8:15 ` Jan Engelhardt
2009-01-16 8:19 ` Patrick McHardy
2009-01-18 7:08 ` James King
2009-01-19 14:29 ` Patrick McHardy
2009-01-15 13:57 ` Troubles with MARK target in 2.6.28 Patrick McHardy
2009-01-15 14:06 ` Pablo Neira Ayuso
2009-01-15 15:51 ` Jan Engelhardt
2009-01-15 15:54 ` Patrick McHardy
2009-01-15 15:58 ` Jan Engelhardt
2009-01-15 16:03 ` Patrick McHardy
2009-01-15 16:20 ` Jan Engelhardt
2009-01-16 7:33 ` Patrick McHardy
2009-01-16 8:14 ` Jan Engelhardt
2009-01-12 18:12 ` Nikolay S. Rybaloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38bcb3ec0901172332y55640cabx86d1200f68f11246@mail.gmail.com \
--to=t.james.king@gmail.com \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).