netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	netfilter-devel@lists.netfilter.org,
	Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH 6/6] netfilter: xt_u32: fix length checks in u32_match_it
Date: Thu, 16 Aug 2007 14:19:12 +0100	[thread overview]
Message-ID: <3a5bf48d1567d7136baaac80dfa4c94f@pinky> (raw)
In-Reply-To: exportbomb.1187270320@pinky


It seems an extraneous trailing ';' has slipped into the skb length
checks in u32_match_it() triggering an unconditional missmatch.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Cc: netfilter-devel@lists.netfilter.org
---
 net/netfilter/xt_u32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/xt_u32.c b/net/netfilter/xt_u32.c
index 74f9b14..bec4279 100644
--- a/net/netfilter/xt_u32.c
+++ b/net/netfilter/xt_u32.c
@@ -36,7 +36,7 @@ static bool u32_match_it(const struct xt_u32 *data,
 		at  = 0;
 		pos = ct->location[0].number;
 
-		if (skb->len < 4 || pos > skb->len - 4);
+		if (skb->len < 4 || pos > skb->len - 4)
 			return false;
 
 		ret   = skb_copy_bits(skb, pos, &n, sizeof(n));

  parent reply	other threads:[~2007-08-16 13:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <exportbomb.1187270320@pinky>
     [not found] ` <20070815235825.GB17004@redhat.com>
2007-08-16  0:40   ` drivers/infiniband/mlx/mad.c misplaced ; Joe Perches
2007-08-16  2:19     ` Kok, Auke
2007-08-16  3:17       ` Joe Perches
2007-08-16  4:20         ` Kok, Auke
2007-08-16 10:21         ` [netfilter-core] " Patrick McHardy
2007-08-16 14:05       ` Andy Whitcroft
2007-08-16  8:46     ` Heiko Carstens
2007-08-16 10:22       ` Ilpo Järvinen
2007-08-16 11:01         ` Karsten Keil
2007-08-18 15:14           ` Daniel Schaffrath
2007-08-16 12:41         ` Satyam Sharma
2007-08-16 14:52     ` Jeff Dike
2007-08-16 16:19     ` Paul Mundt
2007-08-16 13:19 ` Andy Whitcroft [this message]
2007-08-16 14:32   ` [PATCH 6/6] netfilter: xt_u32: fix length checks in u32_match_it Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a5bf48d1567d7136baaac80dfa4c94f@pinky \
    --to=apw@shadowen.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).