From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBF28CCA473 for ; Thu, 9 Jun 2022 23:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345371AbiFIXQP (ORCPT ); Thu, 9 Jun 2022 19:16:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235935AbiFIXQO (ORCPT ); Thu, 9 Jun 2022 19:16:14 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0A453BDF74; Thu, 9 Jun 2022 16:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=s6f6JLtoaOli3gEhHTppp4fmxuJwb8QIU15eBakfOJU=; b=i3qj63WrYUNY43MsN7ARPnlv0w uhTtBf8MplRqkVMB/I9jOTstcPT6ZK+6y7m82ty5GKfMfhF92mGMAti1AG/OXZYAPUeJttdRU6UwF Y5O3WPbkmENJgFLqmh6wbK2eOgNf6Enb7sqWTh7i4qUab45mlSpZ3LVw826gFmWwhHquxIngcAy8S Gm8k4+KVgF6yTPW8u5Ayl956vcUcvRax5+ZOTb0FvlddSrT+XQb2bhvUgG55iQaUkRdpB7qxlpwLW 520dbhk/1P/Z6KN3O1BKt3GiFEJmhyjtSTMfCkQyd2PCnjNlHiclShan1cErMRn8vtPbnPCEOiBYt TO7/TPBA==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzRMu-00DvXN-9e; Thu, 09 Jun 2022 23:15:12 +0000 Message-ID: <3a773edf-f850-e83d-828d-19f91a373384@infradead.org> Date: Thu, 9 Jun 2022 16:14:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 01/12] x86/mce: use correct format characters Content-Language: en-US To: Bill Wendling , isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-2-morbo@google.com> From: Randy Dunlap In-Reply-To: <20220609221702.347522-2-morbo@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On 6/9/22 15:16, Bill Wendling wrote: > From: Bill Wendling > > When compiling with -Wformat, clang emits the following warnings: > > arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > panic(msg); > ^~~ > > Use a string literal for the format string. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Bill Wendling > --- > arch/x86/kernel/cpu/mce/core.c | 2 +- > scripts/Makefile.extrawarn | 4 ++-- Where is the scripts/ change? > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index 2c8ec5c71712..3d411b7c85ad 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) > if (!fake_panic) { > if (panic_timeout == 0) > panic_timeout = mca_cfg.panic_timeout; > - panic(msg); > + panic("%s", msg); > } else > pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); > -- ~Randy