netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Florian Westphal <fw@strlen.de>, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH nf-next] netfilter: nft_meta_bridge: introduce NFT_META_BRI_IIFHWADDR support
Date: Tue, 2 Sep 2025 19:02:10 +0200	[thread overview]
Message-ID: <3aa6619f-e085-4acb-ac47-2aeb545578df@suse.de> (raw)
In-Reply-To: <aLccQ9MN20VExE-4@strlen.de>



On 9/2/25 6:33 PM, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>>>                       +----br0----+
>>>                       |           |
>>> veth0_a------------veth0      veth1--------veth1_b
>>> (192.168.10.10/24)                     (192.168.10.20/24)
>>>
>>> Using the MAC of the port, the packet is consumed by the bridge too and not
>>> forwarded. So, no need for it to be the MAC address of the bridge itself..
>>
>> Thanks for confirming.
>>
>> But this is going to be a bit strange from usability point of view?
>>
>> It is easier to explain to users that by setting the br0 mac address
>> (as we do now) packets are passed up to the local stack.
> 
> Fair point.
> So lets just go with this patch set, forget I said anything :-)
> 
> Fernando, if you have some cycles, would you make a packetpath shell test
> for this to exercise the datapath?
> 

Sure, I can do it. I will create a new test on selftests covering this. 
Should I send a v2 series including the new commit or just send an 
independent series with the selftest changes?

Thanks,
Fernando.

> Thanks!
> 


  reply	other threads:[~2025-09-02 17:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 11:28 [PATCH nf-next] netfilter: nft_meta_bridge: introduce NFT_META_BRI_IIFHWADDR support Fernando Fernandez Mancera
2025-09-02 12:08 ` Florian Westphal
2025-09-02 14:37   ` Pablo Neira Ayuso
2025-09-02 15:34     ` Fernando Fernandez Mancera
2025-09-02 15:58       ` Pablo Neira Ayuso
2025-09-02 16:05         ` Fernando Fernandez Mancera
2025-09-02 16:33         ` Florian Westphal
2025-09-02 17:02           ` Fernando Fernandez Mancera [this message]
2025-09-02 17:07             ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3aa6619f-e085-4acb-ac47-2aeb545578df@suse.de \
    --to=fmancera@suse.de \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).