From: Amos Jeffries <squid3@treenet.co.nz>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 06/10] build: rebuild .pc files when configure status changed
Date: Tue, 19 Oct 2010 21:41:51 +0000 [thread overview]
Message-ID: <3bb88c0985f0036cdbcc2b6307f4c4ce@mail.treenet.co.nz> (raw)
In-Reply-To: <alpine.LNX.2.01.1010191528290.25338@obet.zrqbmnf.qr>
On Tue, 19 Oct 2010 15:30:56 +0200 (CEST), Jan Engelhardt
<jengelh@medozas.de> wrote:
> On Tuesday 2010-10-19 14:14, Amos Jeffries wrote:
>
>> On 19/10/10 23:47, Jan Engelhardt wrote:
>>> Signed-off-by: Jan Engelhardt<jengelh@medozas.de>
>>> ---
>>> Makefile.am | 2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index 35bfbe2..6d5b8dd 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -8,6 +8,8 @@ DIST_SUBDIRS = src include examples
>>> pkgconfigdir = $(libdir)/pkgconfig
>>> pkgconfig_DATA = libmnl.pc
>>>
>>> +${pkgconfig_DATA}: ${top_builddir}/config.status
>>> +
>>> $(OBJECTS): libtool
>>> libtool: $(LIBTOOL_DEPS)
>>> $(SHELL) ./config.status --recheck
>>
>> IIRC {} is a bashism. () is more portable for automake.
>
> What are you talking about? ${...} is not a bash-only feature.
> The automake developers certainly did not complain about the use
> of {} when I submitted my patches.
Okay, they would know best. I'm probably recallling non-linux automakes.
Sorry for the noise.
AYJ
next prev parent reply other threads:[~2010-10-19 21:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 10:47 libmnl build system patches Jan Engelhardt
2010-10-19 10:47 ` [PATCH 01/10] build: just use autoreconf Jan Engelhardt
2010-10-19 10:47 ` [PATCH 02/10] build: do not abuse AM_INIT_AUTOMAKE for autoconf options Jan Engelhardt
2010-10-19 10:47 ` [PATCH 03/10] build: automake options should be in AM_INIT_AUTOMAKE Jan Engelhardt
2010-10-19 10:47 ` [PATCH 04/10] build: use subdir-objects and CC_C_O Jan Engelhardt
2010-10-19 10:47 ` [PATCH 05/10] build: run autoupdate Jan Engelhardt
2010-10-19 10:47 ` [PATCH 06/10] build: rebuild .pc files when configure status changed Jan Engelhardt
2010-10-19 12:14 ` Amos Jeffries
2010-10-19 13:30 ` Jan Engelhardt
2010-10-19 21:41 ` Amos Jeffries [this message]
2010-10-19 10:47 ` [PATCH 07/10] build: resolve compiler warnings Jan Engelhardt
2010-10-19 10:47 ` [PATCH 08/10] build: remove unneeded -dynamic -ldl -nostartfiles flags Jan Engelhardt
2010-10-19 10:47 ` [PATCH 09/10] build: default to not build static libraries Jan Engelhardt
2010-10-19 10:47 ` [PATCH 10/10] Add .gitignore files Jan Engelhardt
2010-10-20 9:37 ` libmnl build system patches Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb88c0985f0036cdbcc2b6307f4c4ce@mail.treenet.co.nz \
--to=squid3@treenet.co.nz \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).