Re: [PATCH] nfnetlink_queue: Use hash to speed up finding entries in nfqueue

[Changli Gao <xiaosuo@gmail.com>]

On Fri, Nov 20, 2009 at 9:56 PM, Patrick McHardy <kaber@trash.net> wrote:
> Changli Gao wrote:
>> On Fri, Nov 20, 2009 at 9:12 PM, Patrick McHardy <kaber@trash.net> wrote:
>>> Changli Gao wrote:
>>>> Use hash to speed up finding entries in nfqueue.
>>>>
>>>> If user implements QoS in userland, packet verdict won't be received in order. At this moment, a hash table is faster than a double linked list when finding the corresponding entries in nfqueue.
>>>>
>>>> This patch also fixes a potential bug, which will allows more than one entries with the same id are in the same nfqueue in the extreme.
>>> Instead of a double ID in a purely hypothetical case, we'd now
>>> get an endless loop. This part doesn't make much sense to me,
>>> please remove it from the patch.
>>>
>>
>> It isn't a endless loop, as we limite the queue size.
>
> It is if queue_maxlen is set to the maximum. In any case this change
> adds a new lookup for ID assignment and complicates the code for a
> case which I still consider purely hypothetical. Additionally it is
> not related to the hashing change and shouldn't be in the same patch.
>

Agree.

-- 
Regards，
Changli Gao(xiaosuo@gmail.com)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html