From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] kill NFC_* stuff in iptables [was Re: iptables compile error: NFC_IP_TOS undeclared]
Date: Sat, 12 Feb 2005 02:32:56 +0100 [thread overview]
Message-ID: <420D5CC8.1060600@trash.net> (raw)
In-Reply-To: <420D27DB.9000608@eurodev.net>
Pablo Neira wrote:
> Patrick McHardy wrote:
>
>> Why didn't you remove it entirely instead ?
>
> true :), patch attached. I've gzip'ed it, it's too big for sending it
> in clear text.
Thanks a lot. Hopeing I don't annoy you .. I haven't actually checked
the API, but can't we remove all those now empty init functions ?
If not I think it would be nicer to change the API to check for
->init == NULL instead of leaving all these empty funtion bodies around.
> Next step, what do you think about removing nfcache passed as
> parameter from the iptables API?
I don't think we can remove it from struct ipt_entry without
breaking userspace compatibility. But we could stop using it.
Regards
Patrick
next prev parent reply other threads:[~2005-02-12 1:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 7:50 netfilter & ipv6 Jonas Berlin
2005-02-10 14:07 ` Jonas Berlin
2005-02-10 14:41 ` Samuel Jean
2005-02-10 15:10 ` iptables compile error: NFC_IP_TOS undeclared Alexander Piavka
2005-02-10 15:18 ` Jonas Berlin
2005-02-10 16:00 ` Alexander Piavka
2005-02-10 16:04 ` Jonas Berlin
2005-02-10 17:50 ` Patrick McHardy
2005-02-10 23:16 ` [PATCH] kill NFC_* stuff in iptables [was Re: iptables compile error: NFC_IP_TOS undeclared] Pablo Neira
2005-02-11 19:07 ` Patrick McHardy
2005-02-11 21:47 ` Pablo Neira
2005-02-12 1:32 ` Patrick McHardy [this message]
2005-02-12 22:25 ` Pablo Neira
2005-02-12 23:34 ` Patrick McHardy
2005-02-10 17:20 ` netfilter & ipv6 Jonas Berlin
2005-02-10 21:36 ` Sven-Haegar Koch
2005-02-15 1:29 ` Jonas Berlin
[not found] ` <53965.213.236.112.75.1107867276.squirrel@213.236.112.75>
2005-02-10 23:15 ` ULOG target for ipv6 Jonas Berlin
2005-02-11 22:10 ` netfilter question Pedro Fortuna
2005-02-14 23:25 ` ULOG target for ipv6 Harald Welte
2005-02-15 0:11 ` Jonas Berlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420D5CC8.1060600@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).