From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] Re: ipt->xt
Date: Mon, 15 Jan 2007 15:51:35 +0100
Message-ID: <45AB94F7.6040806@trash.net>
References: <20070114192011.GA6270@clipper.ens.fr>
	<Pine.LNX.4.61.0701142110250.11926@yvahk01.tjqt.qr>
	<45AB3DCA.9020204@trash.net>
	<Pine.LNX.4.61.0701151109540.32479@yvahk01.tjqt.qr>
	<45AB54E5.6060103@trash.net>
	<Pine.LNX.4.61.0701151526300.13639@yvahk01.tjqt.qr>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: Netfilter Developer Mailing List <netfilter-devel@lists.netfilter.org>
Return-path: <netfilter-devel-bounces@lists.netfilter.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
In-Reply-To: <Pine.LNX.4.61.0701151526300.13639@yvahk01.tjqt.qr>
List-Unsubscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=unsubscribe>
List-Archive: </pipermail/netfilter-devel>
List-Post: <mailto:netfilter-devel@lists.netfilter.org>
List-Help: <mailto:netfilter-devel-request@lists.netfilter.org?subject=help>
List-Subscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=subscribe>
Sender: netfilter-devel-bounces@lists.netfilter.org
Errors-To: netfilter-devel-bounces@lists.netfilter.org
List-Id: netfilter-devel.vger.kernel.org

[CC-list trimmed]

Jan Engelhardt wrote:
> How about this for a start?

A few comments below.

> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
> 
> Index: linux-2.6.20-rc5/net/ipv4/netfilter/ipt_CLUSTERIP.c
> ===================================================================
> --- linux-2.6.20-rc5.orig/net/ipv4/netfilter/ipt_CLUSTERIP.c
> +++ linux-2.6.20-rc5/net/ipv4/netfilter/ipt_CLUSTERIP.c
> @@ -42,7 +43,7 @@
>  
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>");
> -MODULE_DESCRIPTION("iptables target for CLUSTERIP");
> +MODULE_DESCRIPTION("xtables target for CLUSTERIP");

The MODULE_DESCRIPTION should stay the same, its still an iptables-only
target.

> Index: linux-2.6.20-rc5/net/ipv4/netfilter/ipt_LOG.c
> ===================================================================
> --- linux-2.6.20-rc5.orig/net/ipv4/netfilter/ipt_LOG.c
> +++ linux-2.6.20-rc5/net/ipv4/netfilter/ipt_LOG.c
> @@ -20,12 +20,12 @@
>  #include <net/route.h>
>  
>  #include <linux/netfilter.h>
> -#include <linux/netfilter_ipv4/ip_tables.h>
> +#include <linux/netfilter/x_tables.h>
>  #include <linux/netfilter_ipv4/ipt_LOG.h>

Please keep the _ipv4 entries next to each other.

> @@ -471,7 +472,7 @@ static struct nf_logger ipt_log_logger =
>  
>  static int __init ipt_log_init(void)
>  {
> -	if (ipt_register_target(&ipt_log_reg))
> +	if (xt_register_target(&ipt_log_reg))

While you're at it, this should return the real error.

>  		return -EINVAL;
>  	if (nf_log_register(PF_INET, &ipt_log_logger) < 0) {
>  		printk(KERN_WARNING "ipt_LOG: not logging via system console "

> @@ -400,7 +400,7 @@ static int __init ipt_ulog_init(void)
>  	if (!nflognl)
>  		return -ENOMEM;
>  
> -	if (ipt_register_target(&ipt_ulog_reg) != 0) {
> +	if (xt_register_target(&ipt_ulog_reg) != 0) {
>  		sock_release(nflognl->sk_socket);
>  		return -EINVAL;

Same here. Maybe do a seperate patch for these changes.