Re: [Patch 1/2] libnfnetlink, iface conversion to string

[Pablo Neira Ayuso <pablo@netfilter.org>]

Harald Welte wrote:
> There's only some really cosmetic point that I wnat to make: I believe
> it's not always within 80 characters wide lines (or is that just in the
> patch due to different tab expansion?).  But we can do that even after
> the commit ;)

Indeed, I just splitted some line to fit into 80 chars and remove some
blank lines, then I applied the patch to SVN.

Eric, have a look at Documentation/CodingStyle inside the kernel tree,
that is basically the same policy that the netfilter project follows for
everything inside and outside kernel, everyone will appreciate it ;)

BTW, I have inserted a test file under utils/ called iftable.c. I
introduced again two minor changes in the API since the last discussion
to keep it homogeneous with libnfnetlink:

int nlif_index2name(handler, index, name): Now you have to pass a buffer
of IFNAMSIZ where the interface name will be copied, better than the
previous that returns a pointer that needs to be "duplicated".

int nlif_query(handler): Call this function to request a whole dump of
the interface table, you have to call this after nlif_open, but someone
could call it elsewhere to request a whole resync with the interface table.

int nlif_catch(handle): Call this to update the table in the event of
changes

As Harald said, there are more cleanups still pending, like setting
errno to report errors, some possible const'ification, assertions,
probably move to linux_list interface instead of the array of pointers
to interface structures... Once we've solved this stuff I'll prepare
another libraries release.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris