From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@lists.netfilter.org>
Subject: Re: [patch 1/3] Fix return values for LOG and ULOG
Date: Fri, 26 Jan 2007 15:03:57 +0100 [thread overview]
Message-ID: <45BA0A4D.5020609@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0701252213280.15753@yvahk01.tjqt.qr>
Jan Engelhardt wrote:
> [PATCH 1/3] Fix return values for LOG and ULOG
>
> Signed-off-by: Jan Engelhardt <jengelh@gmx.de>, 2007-01-17
>
> Index: linux-2.6.20-rc6/net/ipv4/netfilter/ipt_LOG.c
> ===================================================================
> --- linux-2.6.20-rc6.orig/net/ipv4/netfilter/ipt_LOG.c
> +++ linux-2.6.20-rc6/net/ipv4/netfilter/ipt_LOG.c
> @@ -471,8 +471,9 @@ static struct nf_logger ipt_log_logger =
>
> static int __init ipt_log_init(void)
> {
> - if (ipt_register_target(&ipt_log_reg))
> - return -EINVAL;
> + int ret;
> + if ((ret = ipt_register_target(&ipt_log_reg)) < 0)
> + return ret;
I've changed this to
ret = ...
if (ret < 0)
...
since this is the prefered style. Thanks Jan.
next prev parent reply other threads:[~2007-01-26 14:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 21:12 [patch */3] some xtables changes Jan Engelhardt
2007-01-25 21:14 ` [patch 1/3] Fix return values for LOG and ULOG Jan Engelhardt
2007-01-26 14:03 ` Patrick McHardy [this message]
2007-01-25 21:45 ` [patch 2/3] some xtables changes (xt_match,xt_target) Jan Engelhardt
2007-01-26 14:17 ` Patrick McHardy
2007-01-25 22:15 ` [patch 3/3] some xtables changes (xt_table) Jan Engelhardt
2007-01-26 14:21 ` Patrick McHardy
2007-01-26 16:05 ` [PATCH */3] several messages Jan Engelhardt
2007-01-26 16:18 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2007-01-14 19:20 [patch] netfilter: implement TCPMSS target for IPv6 David Madore
2007-01-14 20:10 ` Jan Engelhardt
2007-01-15 8:39 ` Patrick McHardy
2007-01-15 10:12 ` Jan Engelhardt
2007-01-15 10:18 ` Patrick McHardy
2007-01-15 14:40 ` [PATCH] Re: ipt->xt (was: implement TCPMSS target for IPv6) Jan Engelhardt
2007-01-15 14:51 ` [PATCH] Re: ipt->xt Patrick McHardy
2007-01-15 16:34 ` ipt->xt Jan Engelhardt
2007-01-15 16:36 ` ipt->xt Patrick McHardy
2007-01-15 16:39 ` ipt->xt [p2] Jan Engelhardt
2007-01-17 11:31 ` Patrick McHardy
2007-01-17 12:38 ` Jan Engelhardt
2007-01-17 12:40 ` Patrick McHardy
2007-01-17 13:13 ` ipt->xt [p3] Jan Engelhardt
2007-01-17 13:17 ` Jan Engelhardt
2007-01-17 14:14 ` [PATCH 1/3] Fix return values for LOG and ULOG Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BA0A4D.5020609@trash.net \
--to=kaber@trash.net \
--cc=jengelh@linux01.gwdg.de \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).