From: Patrick McHardy <kaber@trash.net>
To: KOVACS Krisztian <hidden@balabit.hu>
Cc: netfilter-devel@lists.netfilter.org,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: PANIC: divide by zero in xt_connbytes
Date: Sat, 27 Jan 2007 17:36:02 +0100 [thread overview]
Message-ID: <45BB7F72.5010900@trash.net> (raw)
In-Reply-To: <200701262111.44400@nessa>
KOVACS Krisztian wrote:
> On Friday 26 January 2007 18:24, Patrick McHardy wrote:
>
>>I'm wondering what value to use when packets == 0 though,
>>it can't happen for the first packet of a connection since
>>it has already been accounted for before we can match, so
>>the packets counter must have overflown at least once (and
>>the byte counter at least as often as the packet counter).
>
>
> Ok, but what happens if you match on reply packets? I'm quite sure
> something like this will trigger a crash as soon as a new connection
> arrives:
>
> # iptables -A INPUT -m connbytes --connbytes 100: --connbytes-dir \
> reply --connbytes-mode avgpkt -j ACCEPT
You're right of course, I didn't think of that. The patches fixes
this as well (using 0 as average value, which at least in the
"no packets seen so far" case makes sense), but I'm going to fix
the changelog.
prev parent reply other threads:[~2007-01-27 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 10:59 PANIC: divide by zero in xt_connbytes Jonas Berlin
2007-01-18 11:56 ` Bugzilla webserver misconfigured? (was: Re: PANIC: divide by zero in xt_connbytes) Maximilian Wilhelm
2007-01-19 2:43 ` Bugzilla webserver misconfigured? Jonas Berlin
2007-01-18 13:28 ` PANIC: divide by zero in xt_connbytes Pablo Neira Ayuso
2007-01-18 13:38 ` Jonas Berlin
2007-01-18 14:22 ` KOVACS Krisztian
2007-01-22 8:52 ` KOVACS Krisztian
2007-01-26 17:24 ` Patrick McHardy
2007-01-26 20:11 ` KOVACS Krisztian
2007-01-27 16:36 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BB7F72.5010900@trash.net \
--to=kaber@trash.net \
--cc=hidden@balabit.hu \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).