From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2.6.20 08/10] nfnetlink_log: shorten instances_lock holding time Date: Tue, 13 Feb 2007 13:48:31 +0100 Message-ID: <45D1B39F.605@trash.net> References: <20070212004012.GI8262@rere.qmqm.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netfilter-devel@lists.netfilter.org, linux-kernel@vger.org To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Return-path: In-Reply-To: <20070212004012.GI8262@rere.qmqm.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Micha=C2=B3 Miros=C2=B3aw wrote: > Shorten instances_lock window at the cost of doing unnecessary work > on the failure case. I don't know if it makes sense actually. ;> Not really. Its taking the lock whats expensive and we shouldn't have contention here.