netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2.6.20 10/10] nfnetlink_log: enable packet timestamps
@ 2007-02-12  0:40 Michał Mirosław
  2007-02-13 12:49 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Michał Mirosław @ 2007-02-12  0:40 UTC (permalink / raw)
  To: netfilter-devel; +Cc: linux-kernel

It's nice to log packet arrival time of those little filthy packets. ;)

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

--- linux-2.6.20/net/netfilter/nfnetlink_log.c.8	2007-02-11 23:59:01.000000000 +0100
+++ linux-2.6.20/net/netfilter/nfnetlink_log.c	2007-02-12 00:19:16.000000000 +0100
@@ -195,6 +195,10 @@ instance_create(u_int16_t group_num, int
 
 	write_unlock_bh(&instances_lock);
 
+	/* we want timestamps! we want to log those bastards! */
+	if (inst)
+		net_enable_timestamp();
+
 	return inst;
 }
 
@@ -230,6 +234,9 @@ _instance_destroy2(struct nfulnl_instanc
 
 	/* and finally put the refcount */
 	instance_put(inst);
+
+	/* we don't want timestamps anymore (decrement the counter) */
+	net_disable_timestamp();
 }
 
 static inline void

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6.20 10/10] nfnetlink_log: enable packet timestamps
  2007-02-12  0:40 [PATCH 2.6.20 10/10] nfnetlink_log: enable packet timestamps Michał Mirosław
@ 2007-02-13 12:49 ` Patrick McHardy
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2007-02-13 12:49 UTC (permalink / raw)
  To: Michał Mirosław; +Cc: netfilter-devel, linux-kernel

Micha³ Miros³aw wrote:
> It's nice to log packet arrival time of those little filthy packets. ;)

I would prefer to have this explicitly enabled by the user through
the instance configuration since not everyone needs it.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-13 12:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-12  0:40 [PATCH 2.6.20 10/10] nfnetlink_log: enable packet timestamps Michał Mirosław
2007-02-13 12:49 ` Patrick McHardy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).