From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 4/7 parse attributes with nfattr_parse in nfnetlink_check_attribute Date: Wed, 07 Mar 2007 11:43:32 +0100 Message-ID: <45EE9754.8040304@netfilter.org> References: <45D0EE40.4050404@netfilter.org> <45D19B7A.5080305@trash.net> <20070306214527.GD521@postel.suug.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Netfilter Development Mailinglist , Patrick McHardy To: Thomas Graf Return-path: In-Reply-To: <20070306214527.GD521@postel.suug.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Thomas Graf wrote: > * Patrick McHardy 2007-02-13 12:05 >> Pablo Neira Ayuso wrote: >> Currently other netlink subsystems return errors for the first level >> of attributes and accept unknown attributes on deeper levels. I'm >> not sure which I prefer, ignoring unknown attributes makes it >> impossible for userspace to know that something isn't going to have >> any effect, returning an error makes it harder to support new features. >> >> I know Thomas had intentions of increasing consistency in this area, >> I'm just not sure in which direction :) >> >> Thomas, what do you think of this patch? > > I believe that all unknown attributes should be ignored so recent > userspace code can function on older kernels. That's the way I'm > working towards. Then I'll resend the patch if nobody objects anymore ;) -- The dawn of the fourth age of Linux firewalling is coming; a time of great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris