[PATCH] netfilter: xt_tcpudp.c: wrong struct in udp_checkentry

[PATCH] netfilter: xt_tcpudp.c: wrong struct in udp_checkentry

[Jesper Bengtsson]

I found what looks like a copy-paste error in udp_checkentry, see patch
below.
It doesn't seem to have any effect on the x86 architecture but it does
have effect on the Axis CRIS architecture.

Best regards,
Jesper Bengtsson

diff -u -r1.1.1.5 -r1.2
--- net/netfilter/xt_tcpudp.c	6 Mar 2007 08:51:40 -0000	1.1.1.5
+++ net/netfilter/xt_tcpudp.c	24 Aug 2007 09:22:26 -0000	1.2
@@ -191,7 +191,7 @@
 	       void *matchinfo,
 	       unsigned int hook_mask)
 {
-	const struct xt_tcp *udpinfo = matchinfo;
+	const struct xt_udp *udpinfo = matchinfo;
 
 	/* Must specify no unknown invflags */
 	return !(udpinfo->invflags & ~XT_UDP_INV_MASK);

Re: [PATCH] netfilter: xt_tcpudp.c: wrong struct in udp_checkentry

[Patrick McHardy]

Jesper Bengtsson wrote:
> I found what looks like a copy-paste error in udp_checkentry, see patch
> below.
> It doesn't seem to have any effect on the x86 architecture but it does
> have effect on the Axis CRIS architecture.


Thanks, please send me a Signed-off-by: line so I can apply it.

RE: [PATCH] netfilter: xt_tcpudp.c: wrong struct in udp_checkentry

[Jesper Bengtsson]

Hi Patrick,

Signed-off by: Jesper Bengtsson <jesper.bengtsson_at_axis.com>

Thanks,
Jesper


> -----Original Message-----
> From: Patrick McHardy [mailto:kaber@trash.net] 
> Sent: den 29 augusti 2007 19:12
> To: Jesper Bengtsson
> Cc: netfilter-devel@lists.netfilter.org
> Subject: Re: [PATCH] netfilter: xt_tcpudp.c: wrong struct in 
> udp_checkentry
> 
> 
> Jesper Bengtsson wrote:
> > I found what looks like a copy-paste error in 
> udp_checkentry, see patch
> > below.
> > It doesn't seem to have any effect on the x86 architecture 
> but it does
> > have effect on the Axis CRIS architecture.
> 
> 
> Thanks, please send me a Signed-off-by: line so I can apply it.
> 
> 

Re: [PATCH] netfilter: xt_tcpudp.c: wrong struct in udp_checkentry

[Patrick McHardy]

Jesper Bengtsson wrote:
> Signed-off by: Jesper Bengtsson <jesper.bengtsson_at_axis.com>

Applied, thanks Jesper.