netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Craig <philipc@snapgear.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Developer Mailing List <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] libnetfilter_conntrack: Packet/byte counters are 64 bit
Date: Mon, 03 Sep 2007 10:20:00 +1000	[thread overview]
Message-ID: <46DB5330.8050201@snapgear.com> (raw)
In-Reply-To: <46DA7A71.3050909@netfilter.org>

Pablo Neira Ayuso wrote:
> Philip Craig wrote:
>> The counters in struct nf_conntrack are 64 bit, so the getter/setter
>> have to access them as such.
> 
> Still my kernel has 32 bit counters although I know that there was a
> patch on the table to recover 64 bits counters. I'm still getting in
> sync with the development again, did that patch finally hit mainline?

The kernel still sends 32 bit from what I can see, but this is problem
independent of what the kernel sends. The library handles receiving both
32 and 64 bit counters from the kernel, and stores them in a 64 bit
field in a structure. The getter/setter then access that field, but that
doesn't work if they access only 32 bits of it, at least for big endian.

An alternative fix is to change the nf_conntrack field to 32 bit,
but I would only do that if you never intend for the kernel to send
64 bit counters.

      reply	other threads:[~2007-09-03  0:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14  7:19 [PATCH] libnetfilter_conntrack: Packet/byte counters are 64 bit Philip Craig
2007-09-02  8:55 ` Pablo Neira Ayuso
2007-09-03  0:20   ` Philip Craig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DB5330.8050201@snapgear.com \
    --to=philipc@snapgear.com \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).