From: Patrick McHardy <kaber@trash.net>
To: Laszlo Attila Toth <panther@balabit.hu>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: Addrtype match: renaming functions
Date: Thu, 04 Oct 2007 07:00:05 +0200 [thread overview]
Message-ID: <47047355.30005@trash.net> (raw)
In-Reply-To: <4703b9ed.Kwc375N0W4hwnpA7%panther@balabit.hu>
Laszlo Attila Toth wrote:
> Hello,
>
> The function names in libipt_addrtype.c makes debugging hard, also I renamed them
> prefixed by 'addrtype_'.
Applied, thanks Laszlo.
> @@ -191,11 +191,11 @@
> .version = IPTABLES_VERSION,
> .size = IPT_ALIGN(sizeof(struct ipt_addrtype_info)),
> .userspacesize = IPT_ALIGN(sizeof(struct ipt_addrtype_info)),
> - .help = &help,
> - .parse = &parse,
> - .final_check = &final_check,
> - .print = &print,
> - .save = &save,
> + .help = &addrtype_help,
> + .parse = &addrtype_parse,
> + .final_check = &addrtype_final_check,
> + .print = &addrtype_print,
> + .save = &addrtype_save,
Just a hint for future patches: the & is not required, I personally
prefer to omit them. Not worth sending another patch though.
next prev parent reply other threads:[~2007-10-04 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 15:49 Addrtype match: renaming functions Laszlo Attila Toth
2007-10-04 5:00 ` Patrick McHardy [this message]
2007-10-04 6:05 ` Jan Engelhardt
2007-10-04 8:22 ` Laszlo Attila Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47047355.30005@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).