netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: lizf <lizf@cn.fujitsu.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: fix - mistake to pass a pointer where array is required
Date: Thu, 18 Oct 2007 11:05:46 +0200	[thread overview]
Message-ID: <471721EA.4020602@trash.net> (raw)
In-Reply-To: <471720D9.5030901@trash.net>

Patrick McHardy wrote:
> lizf wrote:
>> Sorry for the noise, I've configed my mailer according to a kernel doc,
>> but i'm still not sure whether it works. So here's the attachment.
>>
> 
> Thanks, the attachment applies fine, but does not compile:
> 
> 
>   CC [M]  net/netfilter/xt_sctp.o
> net/netfilter/xt_sctp.c: In function 'match_packet':
> net/netfilter/xt_sctp.c:60: error: 'chunkmap' undeclared (first use in 
> this function)
> net/netfilter/xt_sctp.c:60: error: (Each undeclared identifier is 
> reported only once
> net/netfilter/xt_sctp.c:60: error: for each function it appears in.)
> make[1]: *** [net/netfilter/xt_sctp.o] Error 1
> make: *** [net/netfilter/xt_sctp.o] Error 2
> 
> The SCTP_CHUNKMAP_COPY uses "chunkmap" internally. What tree did
> you base this patch on?


Never mind, I figured out that both patches combined compile,
so I've combined them in one. For the future: each patch should
always compile on its own without errors.


  reply	other threads:[~2007-10-18  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  5:45 [PATCH 1/2] netfilter: fix - mistake to pass a pointer where array is required lizf
2007-10-15  6:07 ` Patrick McHardy
2007-10-15 10:00   ` lizf
2007-10-18  9:01     ` Patrick McHardy
2007-10-18  9:05       ` Patrick McHardy [this message]
2007-10-18  9:14         ` lizf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471721EA.4020602@trash.net \
    --to=kaber@trash.net \
    --cc=lizf@cn.fujitsu.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).