From: Laszlo Attila Toth <panther@balabit.hu>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/2] Interface groups, round two
Date: Thu, 18 Oct 2007 13:34:27 +0200 [thread overview]
Message-ID: <471744C3.3000801@balabit.hu> (raw)
In-Reply-To: <47173354.9060301@trash.net>
Patrick McHardy írta:
> Laszlo Attila Toth wrote:
>> Hello,
>>
>> Here is the new version of ifgroup patches.
>>
>> The interface group value is u_int32_t in net_device which should be
>> enough.
>> Previously it was an int.
>>
>> Usage:
>> ip link set eth0 group 4
>> but currently it cannot be unset, only changed to another value.
>
>
> The only reason why it can't be set to zero again seems to
> be this part from the iproute patch:
>
> + if (rtnl_ifgroup_a2n(&group, *argv) || group == 0)
>
> Why don't you allow a value of zero?
>
It has historical reason. The original version which didn't use netlink
(at kernel 2.6.17) used zero to indicate that group was not set. You
wrote previously that this part is useless for new kernels. I'll fix
this (with type of "group" variable to unsigned int32 to be consistent
with the kernel part).
--
Attila
next prev parent reply other threads:[~2007-10-18 11:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ifgroup-20071018-120757-1192702077-panther@balabit.hu>
2007-10-18 10:13 ` [PATCH 0/2] Interface groups, round two Laszlo Attila Toth
2007-10-18 10:13 ` [IPROUTE PATCH] Interface group as new ip link option Laszlo Attila Toth
2007-10-18 10:13 ` [IPTABLES PATCH] Interface group match Laszlo Attila Toth
2007-10-18 10:15 ` [PATCH 0/2] Interface groups, round two Laszlo Attila Toth
2007-10-18 10:20 ` Patrick McHardy
2007-10-18 11:34 ` Laszlo Attila Toth [this message]
2007-10-18 11:42 ` Patrick McHardy
2007-10-18 10:15 ` Laszlo Attila Toth
[not found] ` <4e88bea1c0065fada9181e9b668a91c6c3fd8796.1192695706.git.panther@balabit.hu>
2007-10-18 10:13 ` [PATCH 1/2] Interface group: core (netlink) part Laszlo Attila Toth
2007-10-18 10:15 ` Laszlo Attila Toth
2007-10-18 10:15 ` Laszlo Attila Toth
2007-10-18 10:22 ` Patrick McHardy
2007-10-19 8:57 ` Laszlo Attila Toth
[not found] ` <7336085b0c4f969c323966058b20836a331b65a1.1192695707.git.panther@balabit.hu>
2007-10-18 10:13 ` [PATCH 2/2] Interface group match Laszlo Attila Toth
2007-10-18 10:15 ` Laszlo Attila Toth
2007-10-18 10:15 ` Laszlo Attila Toth
2007-10-18 10:27 ` Patrick McHardy
2007-10-18 10:15 ` [IPROUTE PATCH] Interface group as new ip link option Laszlo Attila Toth
2007-10-18 10:15 ` [IPTABLES PATCH] Interface group match Laszlo Attila Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471744C3.3000801@balabit.hu \
--to=panther@balabit.hu \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).