libnetfilter_conntrack broken on PPC

libnetfilter_conntrack broken on PPC

[Victor Stinner]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi,

Libnetfilter_conntrack doesn't work on PPC because a small bug in "getters" 
(8, 16, 32 bits). The problem only occurs on big endian architecture and is 
already fixed in subversion. My patch only fix big endian bug, and is very 
small ;-)

I sent the patch to Pablo Neira Ayuso the first october, but he looks very 
busy. Can someone else release a new version of libnetfilter_conntrack? If 
nobody cares, can I get the status of new libnetfilter_conntrack maintainer?

Victor Stinner
http://www.inl.fr/

[-- Attachment #2: api.patch --]
[-- Type: text/x-diff, Size: 948 bytes --]

--- libnetfilter_conntrack-0.0.81/src/conntrack/api.c	2007-06-25 20:40:03.000000000 +0200
+++ libnetfilter_conntrack-trunk/src/conntrack/api.c	2007-09-02 12:02:28.000000000 +0200
@@ -304,7 +304,7 @@
 u_int8_t nfct_get_attr_u8(const struct nf_conntrack *ct,
 			  const enum nf_conntrack_attr type)
 {
-	const int *ret = nfct_get_attr(ct, type);
+	const u_int8_t *ret = nfct_get_attr(ct, type);
 	return ret == NULL ? 0 : *ret;
 }
 
@@ -320,7 +320,7 @@
 u_int16_t nfct_get_attr_u16(const struct nf_conntrack *ct,
 			    const enum nf_conntrack_attr type)
 {
-	const int *ret = nfct_get_attr(ct, type);
+	const u_int16_t *ret = nfct_get_attr(ct, type);
 	return ret == NULL ? 0 : *ret;
 }
 
@@ -336,7 +336,7 @@
 u_int32_t nfct_get_attr_u32(const struct nf_conntrack *ct,
 			    const enum nf_conntrack_attr type)
 {
-	const int *ret = nfct_get_attr(ct, type);
+	const u_int32_t *ret = nfct_get_attr(ct, type);
 	return ret == NULL ? 0 : *ret;
 }
 

Re: libnetfilter_conntrack broken on PPC

[Pablo Neira Ayuso]

Victor Stinner wrote:
> Libnetfilter_conntrack doesn't work on PPC because a small bug in "getters" 
> (8, 16, 32 bits). The problem only occurs on big endian architecture and is 
> already fixed in subversion. My patch only fix big endian bug, and is very 
> small ;-)
> 
> I sent the patch to Pablo Neira Ayuso the first october, but he looks very 
> busy. Can someone else release a new version of libnetfilter_conntrack? If 
> nobody cares, can I get the status of new libnetfilter_conntrack maintainer?

I'll do it along today.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers