netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC] Per-conntrack timeout target
Date: Mon, 19 Nov 2007 11:32:52 +0100	[thread overview]
Message-ID: <47416654.7020300@trash.net> (raw)
In-Reply-To: <20071119014049.GA2013@linuxace.com>

Phil Oester wrote:
> On Sat, Nov 17, 2007 at 08:48:12PM +0100, Patrick McHardy wrote:
>> The only downside I see is that it adds another 4 bytes to the conntrack
>> structure and distributions are probably going to enable it, like
>> everything else. 
> 
> Yep, that's a problem.
> 
>> It would be nice if we could put this in a ct_extend
>> structure, but that would mean you're only able to set it for new
>> connections. What do you think about this?
> 
> Complicates my life, but is the Right Thing.  I'll work on this.
> Should we be considering the same for mark/secmark?


That would be incompatible to todays behaviour, so I think no.
We could of course consider making ct_extend work for confirmed
conntracks, for thats a lot more complicated without adding
extra locking everywhere :) What would work though is to specify
which connections will have manually managed timeouts while they're
unconfirmed (either through a target or by registering a prealloc
type, so we allocate accordingly), and only allow to change the
settings of confirmed connections.

      reply	other threads:[~2007-11-19 10:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-17 18:11 [RFC] Per-conntrack timeout target Phil Oester
2007-11-17 19:48 ` Patrick McHardy
2007-11-19  1:40   ` Phil Oester
2007-11-19 10:32     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47416654.7020300@trash.net \
    --to=kaber@trash.net \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).