From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 2/3] xt_TOS target
Date: Mon, 19 Nov 2007 11:40:09 +0100 [thread overview]
Message-ID: <47416809.60900@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0711161400170.3340@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> Posted for review and checkup.
>
> +++ net-2.6.25/include/linux/netfilter/xt_TOS.h
> @@ -0,0 +1,13 @@
> +#ifndef _XT_TOS_TARGET_H
> +#define _XT_TOS_TARGET_H
> +
> +#ifndef IPTOS_NORMALSVC
> +# define IPTOS_NORMALSVC 0
> +#endif
> +
> +struct xt_tos_target_info {
> + u_int8_t tos_value;
> + u_int8_t tos_mask;
Is the mask thing really useful?
> --- net-2.6.25.orig/include/linux/netfilter_ipv4/Kbuild
> +++ net-2.6.25/include/linux/netfilter_ipv4/Kbuild
> @@ -9,7 +9,6 @@ header-y += ipt_NFQUEUE.h
> header-y += ipt_REJECT.h
> header-y += ipt_SAME.h
> header-y += ipt_TCPMSS.h
> -header-y += ipt_TOS.h
We also need to keep this one I think.
next prev parent reply other threads:[~2007-11-19 10:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 13:00 [PATCH 1/3] xt_tos match Jan Engelhardt
2007-11-16 13:00 ` [PATCH 2/3] xt_TOS target Jan Engelhardt
2007-11-19 10:40 ` Patrick McHardy [this message]
2007-11-19 11:46 ` Jan Engelhardt
2007-11-16 13:01 ` [PATCH 3/3] xt_owner match Jan Engelhardt
2007-11-19 15:43 ` Patrick McHardy
2007-11-19 16:56 ` Jan Engelhardt
2007-11-19 17:08 ` Jan Engelhardt
2007-11-19 17:12 ` Jan Engelhardt
2007-11-19 17:18 ` Patrick McHardy
2007-11-19 17:10 ` Patrick McHardy
2007-11-19 10:37 ` [PATCH 1/3] xt_tos match Patrick McHardy
2007-11-19 11:39 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47416809.60900@trash.net \
--to=kaber@trash.net \
--cc=jengelh@computergmbh.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).