From: Patrick McHardy <kaber@trash.net>
To: Laszlo Attila Toth <panther@balabit.hu>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCHv5 2/2] Addrtype match: limit address type checking to an interface
Date: Mon, 26 Nov 2007 09:11:09 +0100 [thread overview]
Message-ID: <474A7F9D.6070002@trash.net> (raw)
In-Reply-To: <11955456453362-git-send-email-panther@balabit.hu>
Laszlo Attila Toth wrote:
> Addrtype match has a new revision (1), which lets address type checking
> limited to the interface the current packet belongs to. Either incoming
> or outgoing interface can be used depending on the current hook. In the
> FORWARD hook two maches should be used if both interfaces have to be checked.
> The new structure is ipt_addrtype_info_v1.
>
> Revision 0 lets older userspace programs use the match as earlier.
> ipt_addrtype_info is used.
I only applied this to spare you a sixth resend, it had overly long
lines as well and added a useless module alias for the same name.
Anyway, I've fixed up a basically 100% reject with Jan's renaming
patch and applied it.
I still don't like the way the interface is specified very much,
mainly the fact that with the interface limitation you can't
reasonable match on both source and destination type anymore,
so I might change this.
next prev parent reply other threads:[~2007-11-26 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 8:00 [PATCHv5 0/2] Find address type on the packet's interface Laszlo Attila Toth
2007-11-20 8:00 ` [PATCHv5 1/2] Find address type on a specific or on any interface Laszlo Attila Toth
2007-11-20 8:00 ` [PATCHv5 2/2] Addrtype match: limit address type checking to an interface Laszlo Attila Toth
2007-11-20 8:00 ` [PATCHv5 iptables] Address type match: limited to incoming or outgoing interface Laszlo Attila Toth
2007-11-26 8:11 ` Patrick McHardy [this message]
2007-11-26 7:53 ` [PATCHv5 1/2] Find address type on a specific or on any interface Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474A7F9D.6070002@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).