From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [rfc] using xor in mark targets Date: Tue, 04 Dec 2007 15:08:05 +0100 Message-ID: <47555F45.7060001@trash.net> References: <474F4AD4.5030502@trash.net> <47541C45.3090804@trash.net> <47550BC3.9080404@trash.net> <47551B3A.7090100@trash.net> <475531CD.5070604@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:65208 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302AbXLDOIJ (ORCPT ); Tue, 4 Dec 2007 09:08:09 -0500 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Dec 4 2007 11:54, Patrick McHardy wrote: >> Jan Engelhardt wrote: >>> On Dec 4 2007 10:17, Patrick McHardy wrote: >>>> I still don't see why you can't keep --set-mark and add new options >>>> --and-mark, --xor-mark, ... >>>> >>> -j CONNMARK --xor-mark 0x01 >>> -j CONNMARK --and-mark 0xffffffdf >>> -j CONNMARK --or-mark 0x400 >>> >>> I would prefer the single invocation: >>> >>> -j CONNMARK --set-xmark 0x401/0xfffffbdf >> I wouldn't, thats way less readable :) Feel free to add a xmark >> (maybe --raw-mark?) option, but the other ones should still exist >> and --set-mark should behave as currently. >> > If you had looked at the patch, it keeps all the original options :-) "The others" was refering to --and-mark, --or-mark etc.