Re: [PATCH 1/11] Line-based makefile

[Laszlo Attila Toth <panther@balabit.hu>]

Jan Engelhardt írta:
> Transform the extensions' Makefile into a linear form to reduce
> conflicts for patch stacks (very helpful during development).
> Ideally, I'd just push in the automake patch, though,
> which uses wildcards ;-)
> 
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> 
> ---
>  extensions/Makefile |   92 +++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 88 insertions(+), 4 deletions(-)
> 
> Index: iptables-modules/extensions/Makefile
> ===================================================================
> --- iptables-modules.orig/extensions/Makefile
> +++ iptables-modules/extensions/Makefile
> @@ -5,13 +5,97 @@
>  # header files are present in the include/linux directory of this iptables
>  # package (HW)
>  #
> -PF_EXT_SLIB:=ah addrtype conntrack ecn icmp iprange owner policy realm recent tos ttl unclean CLUSTERIP DNAT ECN LOG MASQUERADE MIRROR NETMAP REDIRECT REJECT SAME SNAT TOS TTL ULOG
> -PF6_EXT_SLIB:=ah dst eui64 frag hbh hl icmp6 ipv6header mh owner policy rt HL LOG REJECT
> -PFX_EXT_SLIB:=connbytes connmark connlimit comment dccp dscp esp hashlimit helper length limit mac mark multiport physdev pkttype quota sctp state statistic standard string tcp tcpmss time u32 udp CLASSIFY CONNMARK DSCP MARK NFLOG NFQUEUE NOTRACK TCPMSS TRACE
> +a :=
..
> +a += rt
> +PF6_EXT_SLIB := ${a}
> +a :=
...
> +a += udp
> +PFX_EXT_SLIB := ${a}
>  
>  PF_EXT_SELINUX_SLIB:=
>  PF6_EXT_SELINUX_SLIB:=
> -PFX_EXT_SELINUX_SLIB:=CONNSECMARK SECMARK
> +a :=
> +a += CONNSECMARK
> +a += SECMARK
> +PFX_EXT_SELINUX_SLIB := ${a}
> 

That would be better as
PF_EXT_SLIB :=
PF_EXT_SLIB += ah
and so on.

The other one uses the same variable for every PF_*SLIB also patch
command  may fail.

--
Attila


> 
> -
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html