From: Patrick McHardy <kaber@trash.net>
To: Krzysztof Oledzki <ole@ans.pl>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, gpf <gpf@simm.ru>,
netfilter-devel@vger.kernel.org
Subject: Re: Quota on SMP AGAIN
Date: Mon, 31 Dec 2007 01:19:26 +0100 [thread overview]
Message-ID: <4778358E.2070506@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0712302228490.15993@bizon.gios.gov.pl>
Krzysztof Oledzki wrote:
>
>
> On Fri, 28 Dec 2007, Patrick McHardy wrote:
> <CUT>
>>> And my bigtime question would be: where is the other counter
>>> actually? struct xt_quota_info only has one counter! Does netfilter
>>> secretly allocate matchinfos per-cpu?
>>>
>>
>> Not secretly, but yes, the entire ruleset exists once per CPU. That
>> also seems to be the problem, at the time the master idea was thought
>> of we always dumped entries from CPU 0, today its from the current
>> CPU, but the only one that actually has correct counters is CPU 0.
>
> What happens when CPU#0 is disabled (CPU hotplug)?
Nothing, its simply unused except for counter synchronization and
the ->master thing this thread is about.
next prev parent reply other threads:[~2007-12-31 0:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 15:14 Quota on SMP AGAIN gpf
2007-12-27 15:54 ` Jan Engelhardt
2007-12-27 16:55 ` gpf
2007-12-28 15:26 ` Patrick McHardy
2007-12-28 15:50 ` Jan Engelhardt
2007-12-28 16:13 ` Patrick McHardy
2007-12-28 16:38 ` Jan Engelhardt
2007-12-28 16:50 ` Patrick McHardy
2007-12-28 17:00 ` Jan Engelhardt
2007-12-29 16:32 ` Patrick McHardy
2007-12-29 18:54 ` Krzysztof Oledzki
2007-12-29 19:54 ` Jan Engelhardt
2007-12-30 17:36 ` Patrick McHardy
2007-12-30 18:25 ` Jan Engelhardt
2007-12-30 18:27 ` Patrick McHardy
2007-12-30 21:31 ` Krzysztof Oledzki
2007-12-31 0:19 ` Patrick McHardy [this message]
2007-12-31 0:54 ` Jan Engelhardt
2007-12-31 14:15 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4778358E.2070506@trash.net \
--to=kaber@trash.net \
--cc=gpf@simm.ru \
--cc=jengelh@computergmbh.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).