From: Patrick McHardy <kaber@trash.net>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Harald Welte <laforge@gnumonks.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] ip[6]_tables.c: remove some inlines
Date: Mon, 31 Dec 2007 18:00:34 +0100 [thread overview]
Message-ID: <47792032.3020609@trash.net> (raw)
In-Reply-To: <200712311643.41946.vda.linux@googlemail.com>
Denys Vlasenko wrote:
> ip[6]_tables.c seem to abuse inline.
>
> This patch removes inlines except those which are used
> by packet matching code and thus are performance-critical.
>
Some people also consider the ruleset replacement path performance
critical, but overall I agree with your patch. I'm travelling currently
though so it will take a few days until I'll apply it.
Do you have some numbers that show the actual difference these
changes make?
next prev parent reply other threads:[~2007-12-31 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200712161247.53986.vda.linux@googlemail.com>
2007-12-17 14:47 ` [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines Patrick McHardy
2007-12-27 4:01 ` Denys Vlasenko
2007-12-28 15:30 ` Patrick McHardy
2007-12-31 16:43 ` [PATCH] ip[6]_tables.c: " Denys Vlasenko
2007-12-31 17:00 ` Patrick McHardy [this message]
2007-12-31 17:55 ` Denys Vlasenko
2008-01-08 16:36 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47792032.3020609@trash.net \
--to=kaber@trash.net \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).