From: Patrick McHardy <kaber@trash.net>
To: Peter Warasin <peter@endian.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Fix CONNMARK mask value demolition
Date: Tue, 15 Jan 2008 08:04:42 +0100 [thread overview]
Message-ID: <478C5B0A.0@trash.net> (raw)
In-Reply-To: <4780454E.3050803@endian.com>
Peter Warasin wrote:
> This patch fixes the problem that the CONNMARK mask value
> has been set to 0 whenever the CONNMARK target options has not
> been the last options to be processed.
> @@ -64,13 +64,12 @@
> struct xt_connmark_target_info *markinfo
> = (struct xt_connmark_target_info *)(*target)->data;
>
> - markinfo->mask = 0xffffffffUL;
> -
> switch (c) {
> char *end;
> case '1':
> markinfo->mode = XT_CONNMARK_SET;
>
> + markinfo->mask = 0xffffffffUL;
Good catch, but don't we also need set the mask for --save-mark
and --restore-mark? I would suggest to move the initialzation
to a ->init() function.
next prev parent reply other threads:[~2008-01-15 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 3:04 [PATCH] Fix CONNMARK mask value demolition Peter Warasin
2008-01-09 13:37 ` Peter Warasin
2008-01-15 7:04 ` Patrick McHardy [this message]
2008-01-15 11:45 ` [PATCH v2] " Peter Warasin
2008-01-15 15:46 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478C5B0A.0@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=peter@endian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).