* [PATCH] add netfilter gcc printf format checking
@ 2008-01-06 13:45 Helge Deller
2008-01-06 20:16 ` Helge Deller
0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2008-01-06 13:45 UTC (permalink / raw)
To: netfilter-devel
[PATCH] add netfilter gcc printf format checking
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h
index 16adac6..a335bfc 100644
--- a/include/linux/netfilter.h
+++ b/include/linux/netfilter.h
@@ -181,7 +181,7 @@ void nf_log_packet(int pf,
const struct net_device *in,
const struct net_device *out,
struct nf_loginfo *li,
- const char *fmt, ...);
+ const char *fmt, ...) __printf(7,8);
int nf_hook_slow(int pf, unsigned int hook, struct sk_buff *skb,
struct net_device *indev, struct net_device *outdev,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] add netfilter gcc printf format checking
2008-01-06 13:45 [PATCH] add netfilter gcc printf format checking Helge Deller
@ 2008-01-06 20:16 ` Helge Deller
2008-01-15 7:07 ` Patrick McHardy
0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2008-01-06 20:16 UTC (permalink / raw)
To: netfilter-devel
updated patch below
=================
[PATCH] add netfilter gcc printf format checking
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h
index 16adac6..5d9ecdc 100644
--- a/include/linux/netfilter.h
+++ b/include/linux/netfilter.h
@@ -181,7 +181,7 @@ void nf_log_packet(int pf,
const struct net_device *in,
const struct net_device *out,
struct nf_loginfo *li,
- const char *fmt, ...);
+ const char *fmt, ...) __attribute__ ((format(printf,7,8)));
int nf_hook_slow(int pf, unsigned int hook, struct sk_buff *skb,
struct net_device *indev, struct net_device *outdev,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] add netfilter gcc printf format checking
2008-01-06 20:16 ` Helge Deller
@ 2008-01-15 7:07 ` Patrick McHardy
2008-01-17 21:37 ` Helge Deller
0 siblings, 1 reply; 5+ messages in thread
From: Patrick McHardy @ 2008-01-15 7:07 UTC (permalink / raw)
To: Helge Deller; +Cc: netfilter-devel
Helge Deller wrote:
> updated patch below
> =================
>
> [PATCH] add netfilter gcc printf format checking
This does not apply to the current tree because the logging
functions have been move to a seperate header. Could you
rediff against
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git
please and resend? Ideally wait until my last batch of patches
hits that tree so you don't run into new conflicts.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] add netfilter gcc printf format checking
2008-01-15 7:07 ` Patrick McHardy
@ 2008-01-17 21:37 ` Helge Deller
2008-01-20 13:05 ` Patrick McHardy
0 siblings, 1 reply; 5+ messages in thread
From: Helge Deller @ 2008-01-17 21:37 UTC (permalink / raw)
To: netfilter-devel, davem, Patrick McHardy
updated patch against net-2.6.25 git tree below
=============================
[PATCH] add netfilter gcc printf format checking
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/include/net/netfilter/nf_log.h b/include/net/netfilter/nf_log.h
index 037e824..8c6b5ae 100644
--- a/include/net/netfilter/nf_log.h
+++ b/include/net/netfilter/nf_log.h
@@ -54,6 +54,6 @@ void nf_log_packet(int pf,
const struct net_device *in,
const struct net_device *out,
const struct nf_loginfo *li,
- const char *fmt, ...);
+ const char *fmt, ...) __attribute__ ((format(printf,7,8)));
#endif /* _NF_LOG_H */
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-01-20 13:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-06 13:45 [PATCH] add netfilter gcc printf format checking Helge Deller
2008-01-06 20:16 ` Helge Deller
2008-01-15 7:07 ` Patrick McHardy
2008-01-17 21:37 ` Helge Deller
2008-01-20 13:05 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).