Re: [15/19] libxt_mark r1

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> Introduce libxt_mark match revision 1 support.
> 
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> 
> ---
>  extensions/libxt_mark.c           |  140 ++++++++++++++++++++++++++++++--------
>  include/linux/netfilter/xt_mark.h |    7 +
>  2 files changed, 118 insertions(+), 29 deletions(-)
> 

Applied, thanks.

> +static void mark_mt_help(void)
>  {
>  	printf(
> -"MARK match v%s options:\n"
> -"[!] --mark value[/mask]         Match nfmark value with optional mask\n"
> -"\n",
> -IPTABLES_VERSION);
> +"mark match options:\n"
> +"[!] --mark value[/mask]    Match nfmark value with optional mask\n"
> +"\n");

Not that the version number is particulary useful (only extensions
with matching version numbers are loaded anyways), but this is
kind of the opposite direction of your message unification efforts.
Are you planning to remove them from the other extensions as well?