From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Max Kellermann <max@duempel.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [conntrack-utils PATCH r7285 03/11] moved process function pointer to struct local_server
Date: Wed, 23 Jan 2008 11:45:01 +0100 [thread overview]
Message-ID: <47971AAD.8080805@netfilter.org> (raw)
In-Reply-To: <20080122141051.30077.17154.stgit@rabbit.intern.cm-ag>
Max Kellermann wrote:
> include/local.h | 10 +++++++---
> src/local.c | 11 +++++++----
> src/run.c | 5 +++--
> 3 files changed, 17 insertions(+), 9 deletions(-)
This makes local.c less flexible since it sticks the local socket to a
given handler. With the current approach, you may call different
handlers in do_local_server_step with the same socket. I know, we aren't
using it in that way for now but perhaps in the near future. I have kept
this patch back.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2008-01-23 10:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 14:10 [conntrack-utils PATCH r7285 00/11] conntrackd with libevent Max Kellermann
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 09/11] added handler callback to mcast_sock Max Kellermann
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 10/11] use libevent Max Kellermann
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 11/11] remove the alarm library Max Kellermann
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 02/11] added struct local_server Max Kellermann
2008-01-23 10:36 ` Pablo Neira Ayuso
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 07/11] use size_t Max Kellermann
2008-01-23 12:29 ` Pablo Neira Ayuso
2008-01-23 12:37 ` Max Kellermann
2008-01-23 12:58 ` Pablo Neira Ayuso
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 03/11] moved process function pointer to struct local_server Max Kellermann
2008-01-23 10:45 ` Pablo Neira Ayuso [this message]
2008-01-23 10:52 ` Max Kellermann
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 01/11] -1 means error, not 0 Max Kellermann
2008-01-23 10:16 ` Pablo Neira Ayuso
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 04/11] added alarm_pending() Max Kellermann
2008-01-23 11:50 ` Pablo Neira Ayuso
2008-01-23 11:58 ` Max Kellermann
2008-01-23 12:16 ` Pablo Neira Ayuso
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 08/11] check if the received packet is large enough Max Kellermann
2008-01-23 11:46 ` Pablo Neira Ayuso
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 06/11] remove obsolete prototypes Max Kellermann
2008-01-23 11:15 ` Pablo Neira Ayuso
2008-01-22 14:10 ` [conntrack-utils PATCH r7285 05/11] added missing ntohs() Max Kellermann
2008-01-23 11:07 ` Pablo Neira Ayuso
2008-01-23 12:07 ` [conntrack-utils PATCH r7285 00/11] conntrackd with libevent Pablo Neira Ayuso
2008-01-23 12:26 ` Max Kellermann
2008-01-23 12:50 ` Pablo Neira Ayuso
2008-01-25 18:01 ` Pablo Neira Ayuso
2008-01-25 18:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47971AAD.8080805@netfilter.org \
--to=pablo@netfilter.org \
--cc=max@duempel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).