From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
devel@openvz.org
Subject: Re: [PATCH 1/5] netns netfilter: per-netns ip6tables
Date: Thu, 24 Jan 2008 18:33:37 +0100 [thread overview]
Message-ID: <4798CBF1.205@trash.net> (raw)
In-Reply-To: <20080124122328.GA27337@localhost.sw.ru>
Alexey Dobriyan wrote:
> * Propagate netns from userspace down to xt_find_table_lock()
> * Register ip6 tables in netns (modules still use init_net)
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
>
> include/linux/netfilter_ipv6/ip6_tables.h | 3 +
> net/ipv6/netfilter/ip6_tables.c | 50 +++++++++++++++---------------
> net/ipv6/netfilter/ip6table_filter.c | 2 -
> net/ipv6/netfilter/ip6table_mangle.c | 2 -
> net/ipv6/netfilter/ip6table_raw.c | 2 -
> 5 files changed, 31 insertions(+), 28 deletions(-)
This adds checkpatch warnings:
WARNING: line over 80 characters
#96: FILE: net/ipv6/netfilter/ip6_tables.c:1361:
+do_add_counters(struct net *net, void __user *user, unsigned int len,
int compat)
WARNING: line over 80 characters
#229: FILE: net/ipv6/netfilter/ip6table_filter.c:135:
+ packet_filter = ip6t_register_table(&init_net, &__packet_filter,
&initial_table.repl);
WARNING: line over 80 characters
#242: FILE: net/ipv6/netfilter/ip6table_mangle.c:167:
+ packet_mangler = ip6t_register_table(&init_net,
&__packet_mangler, &initial_table.repl);
WARNING: line over 80 characters
#255: FILE: net/ipv6/netfilter/ip6table_raw.c:80:
+ packet_raw = ip6t_register_table(&init_net, &__packet_raw,
&initial_table.repl);
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 4 warnings, 214 lines checked
I'll fix them up, lets hope that it doesn't cause clashes
with the following patches.
next prev parent reply other threads:[~2008-01-24 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 12:23 [PATCH 1/5] netns netfilter: per-netns ip6tables Alexey Dobriyan
2008-01-24 17:33 ` Patrick McHardy [this message]
2008-01-25 16:39 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4798CBF1.205@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@sw.ru \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).