From: Patrick McHardy <kaber@trash.net>
To: Holger Eitzenberger <heitzenberger@astaro.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [ULOGD RFC 08/30] NFCT: rework
Date: Fri, 01 Feb 2008 10:11:50 +0100 [thread overview]
Message-ID: <47A2E256.6080600@trash.net> (raw)
In-Reply-To: <87r6fx14j1.fsf@kruemel.intranet.astaro.de>
Holger Eitzenberger wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> writes:
>
>> Well, this NFCT stuff is a big hack. I'm sure that you have solved
>> several issues with those patches but sorry, I don't like them at all.
>> There's several parts of conntrackd that we could use to rework this eg.
>> an implementation of a generic hash table in conntrackd that we can
>> reuse and nfnl_recv_msgs looks very similar to nfnl_catch, etc. Also,
>> the ENOBUFS handling is still a mess. I'm better keeping back these NFCT
>> patches. I'll try to give some spins to it.
>
> Hi Pablo,
>
> are you talking about this particular patch or the end result after
> applying all of the NFCT patches?
>
> Also note that IMO this particular patch turned a non-working NFCT
> solution into some better-working solution. I just suggest to
> comment on the final NFCT code and not on this one. Thanks.
I agree, this code has bitrotten for too long, I'm happy about
any progress. Any objections should be clearly stated please.
next prev parent reply other threads:[~2008-02-01 9:11 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 18:58 [ULOGD RFC 00/30] [ULOGD RFC] ulogd V2 improvements, round #1 heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 01/30] Add NACCT output plugin heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 02/30] common.h: added heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 03/30] Replace timer code by working version heitzenberger
2008-02-01 3:42 ` Pablo Neira Ayuso
2008-02-01 8:15 ` Holger Eitzenberger
2008-02-01 9:25 ` Patrick McHardy
2008-02-01 9:43 ` Holger Eitzenberger
2008-02-01 9:51 ` Patrick McHardy
2008-01-30 18:58 ` [ULOGD RFC 04/30] Add IFI list heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 05/30] Add signalling subsystem heitzenberger
2008-02-01 3:46 ` Pablo Neira Ayuso
2008-02-01 8:18 ` Holger Eitzenberger
2008-02-01 9:17 ` Patrick McHardy
2008-02-01 9:30 ` Holger Eitzenberger
2008-02-01 10:11 ` Holger Eitzenberger
2008-01-30 18:58 ` [ULOGD RFC 06/30] Conffile cleanup, use common pr_debug() heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 07/30] Renice to -1 on startup heitzenberger
2008-02-01 3:47 ` Pablo Neira Ayuso
2008-02-01 7:19 ` Patrick McHardy
2008-02-01 9:12 ` Holger Eitzenberger
2008-01-30 18:58 ` [ULOGD RFC 08/30] NFCT: rework heitzenberger
2008-02-01 1:23 ` Pablo Neira Ayuso
2008-02-01 8:09 ` Holger Eitzenberger
2008-02-01 9:11 ` Patrick McHardy [this message]
2008-02-01 13:37 ` Pablo Neira Ayuso
2008-02-01 16:19 ` Holger Eitzenberger
2008-02-01 16:47 ` Pablo Neira Ayuso
2008-02-01 17:06 ` Holger Eitzenberger
2008-02-02 21:10 ` Pablo Neira Ayuso
2008-02-01 9:10 ` Patrick McHardy
2008-02-01 9:38 ` Patrick McHardy
2008-02-02 16:20 ` [PATCH] " Eric Leblond
2008-02-02 20:07 ` Holger Eitzenberger
2008-01-30 18:58 ` [ULOGD RFC 09/30] Port to ulogd 2.00, mostly a rewrite heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 10/30] Initial round to make plugins reconfigurable heitzenberger
2008-01-30 18:58 ` [ULOGD RFC 11/30] NFCT: make reconfigurable heitzenberger
2008-01-30 19:30 ` NFCT ulogd pluging [was Re: [ULOGD RFC 11/30] NFCT: make reconfigurable] Pablo Neira Ayuso
2008-01-30 19:51 ` Patrick McHardy
2008-01-30 20:39 ` Harald Welte
2008-01-30 21:04 ` Holger Eitzenberger
2008-02-01 1:17 ` Pablo Neira Ayuso
2008-01-30 18:58 ` [ULOGD RFC 12/30] SQLITE3: make reconfigurable heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 13/30] NFCT: add disable switch heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 14/30] SQLITLE3: " heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 15/30] NFCT: add sequence cache heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 16/30] SQLITE3: handle locked DB smarter heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 17/30] NFCT: use localtime for timestamps heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 18/30] NFCT: properly account both directions in all cases heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 19/30] llist: add llist_for_each_prev_safe() heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 20/30] SQLITE3: generalize error handling heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 21/30] Improve select performance heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 22/30] Add set_sockbuf_len() heitzenberger
2008-02-01 3:50 ` Pablo Neira Ayuso
2008-02-01 8:20 ` Holger Eitzenberger
2008-02-01 9:20 ` Patrick McHardy
2008-01-30 18:59 ` [ULOGD RFC 23/30] NFCT: make sequence cache bigger, make handling smarter heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 24/30] NFCT: increase socket buffers heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 25/30] Introduce global state, skip some stacks during reconfiguration heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 26/30] llist: turn poisoning off by default heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 27/30] NFCT: cleanup direction handling heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 28/30] NFCT: fix start/stop handling heitzenberger
2008-01-30 18:59 ` [ULOGD RFC 29/30] NFCT: adapt to new libnetfilter_conntrack heitzenberger
2008-02-01 3:55 ` Pablo Neira Ayuso
2008-02-01 8:33 ` Holger Eitzenberger
2008-01-30 18:59 ` [ULOGD RFC 30/30] SQLITE3: move timer initialization to start handler heitzenberger
2008-01-30 19:18 ` [ULOGD RFC 00/30] [ULOGD RFC] ulogd V2 improvements, round #1 Patrick McHardy
2008-01-30 20:59 ` Holger Eitzenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47A2E256.6080600@trash.net \
--to=kaber@trash.net \
--cc=heitzenberger@astaro.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox