Re: [PATCHv3 2/5] Adds AF_BRIDGE and ARP header interpreter to BASE plugin

[Pablo Neira Ayuso <pablo@netfilter.org>]

Peter Warasin wrote:
> Eric Leblond wrote:
>> I did not drink cofee this morning, and thus I may be wrong, but it seems
>> you've sent the same patch as yesterday. KEY_ARP_SPA is still of type RAW
>> for example. The other patch seems also unchanged.
>>   
> 
> Oh my. I think it was to late yesterday. Took the
> wrong directory :/
> 
> Here is the correct patch attached.
> I hope so, did not drink coffee either :)

Hm, I get this warnings with your patch:

ulogd_raw2packet_BASE.c: In function '_interp_arp':
ulogd_raw2packet_BASE.c:899: warning: assignment makes integer from
pointer without a cast
ulogd_raw2packet_BASE.c:904: warning: assignment makes integer from
pointer without a cast

> +	ret[KEY_ARP_SHA].u.value.ptr = &arph->arp_sha;
> +	SET_VALID(ret[KEY_ARP_SHA]);
> +	ret[KEY_ARP_SPA].u.value.ui32 = &arph->arp_spa;
> +	SET_VALID(ret[KEY_ARP_SPA]);
> +
> +	ret[KEY_ARP_THA].u.value.ptr = &arph->arp_tha;
> +	SET_VALID(ret[KEY_ARP_THA]);
> +	ret[KEY_ARP_TPA].u.value.ui32 = &arph->arp_tpa;
> +	SET_VALID(ret[KEY_ARP_TPA]);

Now arp_spa and arp_tpa use ptr instead of ui32. Please, clarify.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers