Re: [ULOGD 11/15] Add set_sockbuf_len()

[Pablo Neira Ayuso <pablo@netfilter.org>]

heitzenberger@astaro.com wrote:
> +	if (snd_len > 0) {
> +		ret = setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &snd_len,
> +						 sizeof(snd_len));
> +		if (ret < 0) {
> +			ulogd_log(ULOGD_ERROR, "setsockopt: SO_SNDBUF: %m\n");
> +			return -1;
> +		}
> +	}
> +
> +	if (rcv_len > 0) {
> +		ret = setsockopt(fd, SOL_SOCKET, SO_RCVBUF, &rcv_len,
> +						 sizeof(rcv_len));
> +		if (ret < 0) {
> +			ulogd_log(ULOGD_ERROR, "setsockopt: SO_RCVBUF: %m\n");
> +			return -1;
> +		}
> +	}

I guess that this is meant to increase the size of the netlink buffers,
isn't this? However, where's the client of this code?

Please, next time put the new code with its client so I can easily
notice what you want to do by looking at a single patch, otherwise I'll
have to look at the entire patchset to search for its client. A short
rationale on the benefits of the patch would also help.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers