* [NETFILTER]: xt_conntrack: fix missing boolean clamping
@ 2008-02-21 13:57 Jan Engelhardt
2008-02-21 14:06 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2008-02-21 13:57 UTC (permalink / raw)
To: kaber; +Cc: Netfilter Developer Mailing List
commit 14c8c528a0ee9f0468be251cf3d16029924ee422
Author: Jan Engelhardt <jengelh@computergmbh.de>
Date: Thu Feb 21 14:57:01 2008 +0100
[NETFILTER]: xt_conntrack: fix missing boolean clamping
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
diff --git a/net/netfilter/xt_conntrack.c b/net/netfilter/xt_conntrack.c
index 8533085..dd192ac 100644
--- a/net/netfilter/xt_conntrack.c
+++ b/net/netfilter/xt_conntrack.c
@@ -231,7 +231,7 @@ conntrack_mt(const struct sk_buff *skb, const struct net_device *in,
if (test_bit(IPS_DST_NAT_BIT, &ct->status))
statebit |= XT_CONNTRACK_STATE_DNAT;
}
- if ((info->state_mask & statebit) ^
+ if (!!(info->state_mask & statebit) ^
!(info->invert_flags & XT_CONNTRACK_STATE))
return false;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [NETFILTER]: xt_conntrack: fix missing boolean clamping
2008-02-21 13:57 [NETFILTER]: xt_conntrack: fix missing boolean clamping Jan Engelhardt
@ 2008-02-21 14:06 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-02-21 14:06 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Netfilter Developer Mailing List
Jan Engelhardt wrote:
> commit 14c8c528a0ee9f0468be251cf3d16029924ee422
> Author: Jan Engelhardt <jengelh@computergmbh.de>
> Date: Thu Feb 21 14:57:01 2008 +0100
>
> [NETFILTER]: xt_conntrack: fix missing boolean clamping
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-21 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-21 13:57 [NETFILTER]: xt_conntrack: fix missing boolean clamping Jan Engelhardt
2008-02-21 14:06 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).