From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: nf_nat_core just using l3proto_find_get
Date: Tue, 11 Mar 2008 15:05:57 +0100 [thread overview]
Message-ID: <47D691C5.7010907@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0803102259100.21961@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Feb 19 2008 13:22, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> I just noticed that nf_nat_core.c uses
>>>
>>> l3proto = nf_ct_l3proto_find_get((u_int16_t)AF_INET);
>>>
>>> in its nf_nat_init() function. Why is not it using
>>> nf_ct_l3proto_module_try_get here?
>> There is no such function, nf_ct_l3proto_find_get() takes a
>> module reference.
>>
> Hm?
>
> [...]
>
> leading to the original question why nf_nat_core does not use
> nf_ct_l3proto_try_module_get.
Why should it? There's no need for manual module loading since
there already is a symbol dependency.
next prev parent reply other threads:[~2008-03-11 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 2:10 nf_nat_core just using l3proto_find_get Jan Engelhardt
2008-02-19 12:22 ` Patrick McHardy
2008-03-10 22:01 ` Jan Engelhardt
2008-03-11 14:05 ` Patrick McHardy [this message]
2008-03-11 14:16 ` Jan Engelhardt
2008-03-11 14:20 ` Patrick McHardy
2008-03-11 19:42 ` Jan Engelhardt
2008-03-17 14:01 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D691C5.7010907@trash.net \
--to=kaber@trash.net \
--cc=jengelh@computergmbh.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).