From: Patrick McHardy <kaber@trash.net>
To: "Tseng, Kuo-Lang" <kuo-lang.tseng@intel.com>
Cc: netfilter-devel@vger.kernel.org,
Bart De Schuymer <bdschuym@pandora.be>,
ebtables-devel@lists.sourceforge.net
Subject: Re: [Ebtables-devel] [PATCH 2/2] Add IPv6 support
Date: Tue, 08 Apr 2008 19:37:59 +0200 [thread overview]
Message-ID: <47FBAD77.2050701@trash.net> (raw)
In-Reply-To: <3F25FE8C477E9E4FB3D42C2FF937C08A8D0B6D@orsmsx423.amr.corp.intel.com>
Tseng, Kuo-Lang wrote:
> Tseng, Kuo-Lang wrote on Monday, February 18, 2008 6:05 PM:
>
>> This is the corresponding br-netfilter patch.
>>
>> It implements matching functions for IPv6 address & traffic class
>> (merged from the patch sent by Jan Engelhardt
>> [jengelh@computergmbh.de]
>> http://marc.info/?l=netfilter-devel&m=120182168424052&w=2), protocol,
>> and layer-4 port id. Corresponding watcher logging function is also
>> added for IPv6.
>>
>> Signed-off-by: Kuo-lang Tseng <kuo-lang.tseng@intel.com>
>
> Reposting the patch as an attachment (earlier one had line split. Sorry
> about that)
I wanted to apply this, but the patch has multiple checkpatch
errors. There are also some codingstyle errors checkpatch doesn't
complain about, like:
+ for (i = 0; i < 4; i++)
+ tmp_addr.in6_u.u6_addr32[i] = ih6->saddr.in6_u.u6_addr32[i] &
^^^ needs tab
It also seems the TCP/UDP/.. logging part could be shared between
IPv4 and IPv6. The protocol checks seem to be missing UDPLITE.
Please fix those up and resend, thanks.
next prev parent reply other threads:[~2008-04-08 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.53487.1201131436.6775.ebtables-devel@lists.sourceforge.net>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A72D8D4@orsmsx423.amr.corp.intel.com>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A767706@orsmsx423.amr.corp.intel.com>
[not found] ` <1201303354.2909.1.camel@localhost.localdomain>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A82039A@orsmsx423.amr.corp.intel.com>
[not found] ` <Pine.LNX.4.64.0802070130120.23855@fbirervta.pbzchgretzou.qr>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A85CA7F@orsmsx423.amr.corp.intel.com>
[not found] ` <Pine.LNX.4.64.0802080126020.25157@fbirervta.pbzchgretzou.qr>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A85CB14@orsmsx423.amr.corp.intel.com>
[not found] ` <1202494854.2895.11.camel@localhost.localdomain>
2008-02-09 0:49 ` Ebtables plans Jan Engelhardt
2008-02-11 20:57 ` Bart De Schuymer
2008-02-16 22:49 ` Jan Engelhardt
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A85D069@orsmsx423.amr.corp.intel.com>
[not found] ` <1202664082.2907.5.camel@localhost.localdomain>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A85D440@o rsmsx423.amr.corp.intel.com>
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A85D440@orsmsx423.amr.corp.intel.com>
2008-02-12 2:26 ` [Ebtables-devel] [PATCH] IPv6 dnat/snat support Tseng, Kuo-Lang
2008-02-12 2:43 ` Jan Engelhardt
[not found] ` <Pine.LNX.4.64.0802120333400.29955-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
2008-02-19 1:49 ` [PATCH 0/2] Add IPv6 support Tseng, Kuo-Lang
[not found] ` <3F25FE8C477E9E4FB3D42C2FF937C08A8D0909-7XlYjKTK0pNQxe9IK+vIArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2008-02-19 15:03 ` Patrick McHardy
2008-02-19 17:46 ` [Ebtables-devel] " Bart De Schuymer
2008-02-26 19:08 ` Tseng, Kuo-Lang
2008-02-26 19:11 ` Tseng, Kuo-Lang
[not found] ` <Pine.LNX.4.64.0802070130120.23855-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
2008-02-19 2:05 ` [PATCH 2/2] " Tseng, Kuo-Lang
2008-02-19 18:27 ` [Ebtables-devel] " Tseng, Kuo-Lang
2008-04-08 17:37 ` Patrick McHardy [this message]
[not found] ` <47FBAD77.2050701-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-04-10 20:23 ` Tseng, Kuo-Lang
2008-04-21 4:50 ` [Ebtables-devel] " Tseng, Kuo-Lang
2008-04-21 14:41 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FBAD77.2050701@trash.net \
--to=kaber@trash.net \
--cc=bdschuym@pandora.be \
--cc=ebtables-devel@lists.sourceforge.net \
--cc=kuo-lang.tseng@intel.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox