From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/8] [NETFILTER]: Use unsigned types for hooknum and pf vars
Date: Wed, 09 Apr 2008 18:21:17 +0200 [thread overview]
Message-ID: <47FCECFD.3050201@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0804091817420.3866@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Tuesday 2008-04-08 17:10, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> and (try to) consistently use u_int16_t for the L3 family.
>> Let me think about this. I know I suggested to use u_int16_t,
>> but ypur last patch was only for conntrack, and thats what it
>> uses in the tuple (only to fill a hole). The protocol is
>> *actually* a u8, and thats also what all the others use or
>> should use.
>
> So your resolution is..- moving everything to uint8?
>
None so far, I've been kept busy responding to emails.
next prev parent reply other threads:[~2008-04-09 16:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 14:17 0/8 Netfilter patches (group 1) Jan Engelhardt
2008-04-08 14:17 ` [PATCH 1/8] [NETFILTER]: Use bool type in struct nf_conntrack_l3proto Jan Engelhardt
2008-04-08 14:17 ` [PATCH 2/8] [NETFILTER]: Use bool type in struct nf_conntrack_l4proto Jan Engelhardt
2008-04-08 15:05 ` Patrick McHardy
2008-04-08 14:17 ` [PATCH 3/8] [NETFILTER]: Use unsigned types for hooknum and pf vars Jan Engelhardt
2008-04-08 15:10 ` Patrick McHardy
2008-04-09 16:18 ` Jan Engelhardt
2008-04-09 16:21 ` Patrick McHardy [this message]
2008-04-12 8:40 ` Jan Engelhardt
2008-04-08 14:17 ` [PATCH 4/8] [NETFILTER]: Use bool type in struct nf_conntrack_tuple.h Jan Engelhardt
2008-04-08 15:12 ` Patrick McHardy
2008-04-08 14:17 ` [PATCH 5/8] [NETFILTER]: Use bool type in nf_nat_proto Jan Engelhardt
2008-04-08 15:16 ` Patrick McHardy
2008-04-08 14:17 ` [PATCH 6/8] [NETFILTER]: const annotations in nf_conntrack_{sctp,dccp}, nf_nat_proto_gre Jan Engelhardt
2008-04-08 15:19 ` Patrick McHardy
2008-04-08 14:17 ` [PATCH 7/8] [NETFILTER]: Replace NF_CT_DUMP_TUPLE macro indrection by function call Jan Engelhardt
2008-04-08 15:21 ` Patrick McHardy
2008-04-08 14:17 ` [PATCH 8/8] [NETFILTER]: xt_length match, revision 1 Jan Engelhardt
2008-04-08 15:28 ` Patrick McHardy
2008-04-09 16:18 ` Jan Engelhardt
2008-04-09 16:25 ` Patrick McHardy
2008-04-12 6:38 ` Jan Engelhardt
2008-04-08 15:03 ` [PATCH 1/8] [NETFILTER]: Use bool type in struct nf_conntrack_l3proto Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FCECFD.3050201@trash.net \
--to=kaber@trash.net \
--cc=jengelh@computergmbh.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox