Linux Netfilter development
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 08/10] Remove old functions, constants
Date: Tue, 15 Apr 2008 13:50:19 +0200	[thread overview]
Message-ID: <4804967B.40104@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0804151348470.13202@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Tuesday 2008-04-15 13:47, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> 	printf(
>>> -"LOG v%s options:\n"
>>> +"LOG target options:\n"
>>> " --log-level level		Level of logging (numeric or see
>>> syslog.conf)\n"
>>> -" --log-prefix prefix		Prefix log messages with this
>>> prefix.\n\n"
>>> -" --log-tcp-sequence		Log TCP sequence numbers.\n\n"
>>> -" --log-tcp-options		Log TCP options.\n\n"
>>> -" --log-ip-options		Log IP options.\n\n"
>>> -" --log-uid			Log UID owning the local socket.\n\n",
>>> -IPTABLES_VERSION);
>>> +" --log-prefix prefix		Prefix log messages with this
>>> prefix.\n"
>>> +" --log-tcp-sequence		Log TCP sequence numbers.\n"
>>> +" --log-tcp-options		Log TCP options.\n"
>>> +" --log-ip-options		Log IP options.\n"
>>> +" --log-uid			Log UID owning the local socket.\n");
>>>  }
>>
>> This doesn't match the patch description. Why are you
>> changing help texts?
>>
> These are just the newlines; to follow the style of the other extensions.
> 

OK, I'll apply it.

      reply	other threads:[~2008-04-15 11:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-15 10:33 iptables updates Jan Engelhardt
2008-04-15 10:33 ` [PATCH 01/10] Resolve warnings on 64-bit compile Jan Engelhardt
2008-04-15 10:33   ` [PATCH 02/10] Wrap dlopen code into NO_SHARED_LIBS Jan Engelhardt
2008-04-15 11:38     ` Patrick McHardy
2008-04-15 10:33   ` [PATCH 03/10] Remove support for compilation of conditional extensions Jan Engelhardt
2008-04-15 11:41     ` Patrick McHardy
2008-04-15 10:33   ` [PATCH 04/10] Resolve libipt_set warnings Jan Engelhardt
2008-04-15 11:42     ` Patrick McHardy
2008-04-15 10:33   ` [PATCH 05/10] Update documentation about building the package Jan Engelhardt
2008-04-15 11:43     ` Patrick McHardy
2008-04-15 10:33   ` [PATCH 06/10] configure.ac: AC_SUBST must be separate Jan Engelhardt
2008-04-15 11:43     ` Patrick McHardy
2008-04-15 10:33   ` [PATCH 07/10] Dynamically create xtables.h.in with version Jan Engelhardt
2008-04-15 11:44     ` Patrick McHardy
2008-04-15 10:33   ` [PATCH 09/10] Move libipt_recent to libxt_recent Jan Engelhardt
2008-04-15 10:33   ` [PATCH 10/10] libxt_recent: add missing --rsource,--rdest options to manpage Jan Engelhardt
2008-04-15 11:38   ` [PATCH 01/10] Resolve warnings on 64-bit compile Patrick McHardy
2008-04-15 11:19 ` [PATCH 11] configure.ac: remove already-defined variables Jan Engelhardt
2008-04-15 11:48   ` Patrick McHardy
     [not found] ` <7c7d0eb43b7b4ca3711ae0dbe17ae7ef66fb02f8.1208255176.git.jengelh@computergmbh.de>
2008-04-15 11:47   ` [PATCH 08/10] Remove old functions, constants Patrick McHardy
2008-04-15 11:49     ` Jan Engelhardt
2008-04-15 11:50       ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4804967B.40104@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox