Re: [ULOGD PATCH 1/7] Add label option to NFLOG input plugin.

[Pablo Neira Ayuso <pablo@netfilter.org>]

Eric Leblond wrote:
> Hello,
> 
> On Sunday, 2008 April 27 at  9:27:35 +0200, Pablo Neira Ayuso wrote:
>> Eric Leblond wrote:
>>> @@ -78,6 +78,13 @@ static struct config_keyset libulog_kset = {
>>>  			.options = CONFIG_OPT_NONE,
>>>  			.u.value = 0,
>>>  		},
>>> +		{
>>> +			.key	 = "label",
>>> +			.type	 = CONFIG_TYPE_INT,
>>> +			.options = CONFIG_OPT_NONE,
>>> +			.u.value = 0,
>>> +		},
>>> +
>>>  	}
>>>  };
>> Wouldn't it better if we use a string instead of an integer? Thus, this
>> will really work as labeler.
> 
> We already have the log prefix for a string label usage. I think it will
> brought confusion to have both a string log prefix and a string label.
> Furthermore, the goal of the label is to be able to classify packets and
> an integer will be faster (in the database), stricter (to avoid
> confusion) and smaller (to store) than a string.

OK, then I'd prefer if we change the name again to "numberic_label". 
Sorry for the annoyance.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers