Linux Netfilter development
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Henrik Nordstrom <henrik@henriknordstrom.net>,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: [Patch] Re: Line numbering broken since bb34082d
Date: Fri, 13 Jun 2008 17:58:36 +0200	[thread overview]
Message-ID: <4852992C.5050106@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0806131418320.23098@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Friday 2008-06-13 12:59, Henrik Nordstrom wrote:
>> On fre, 2008-06-13 at 11:14 +0200, Jan Engelhardt wrote:
>>
>>> `iptables -nvL --lin`, starting with bb34082de, gives a wrong count:
>>>
>>> Chain FORWARD (policy ACCEPT 0 packets, 0 bytes)
>>> num   pkts bytes target     prot opt in     out     source               
>>> destination         
>>> 2        0     0 LOG        all  --  *      *       0.0.0.0/0            
>>> 0.0.0.0/0           LOG flags 0 level 4 
>> Sorry about that. Never tested --line-numbers.
>>
>> I think the best fix is to drop the +1 from print_firewall(). Patch attached.
> 
> Indeed, that is the right thing to do, since with my patch,
> iptables -nvL INPUT 1  would still show the 2nd rule.


Thanks, I applied Henrik's patch with your description.

      reply	other threads:[~2008-06-13 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13  9:14 Line numbering broken since bb34082d Jan Engelhardt
2008-06-13 10:59 ` [Patch] " Henrik Nordstrom
2008-06-13 12:19   ` Jan Engelhardt
2008-06-13 15:58     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4852992C.5050106@trash.net \
    --to=kaber@trash.net \
    --cc=henrik@henriknordstrom.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox