From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Eric Leblond <eric@inl.fr>, netfilter-devel@vger.kernel.org
Subject: Re: [ULOGD2 PATCH 0/4] Misc cleaning
Date: Wed, 23 Jul 2008 16:43:56 +0200 [thread overview]
Message-ID: <488743AC.4040909@trash.net> (raw)
In-Reply-To: <48873F55.2000706@netfilter.org>
Pablo Neira Ayuso wrote:
> Eric Leblond wrote:
>> The main concern here is about IPFIX which is in really bad shape. I've fix
>> some major error in one of the patch but it remains untested for now and I
>> don't think it can work properly.
>
> Indeed. It's broken Do you plan to look into this? If not, I'll fix it
> myself. Please, let me know since I don't want to duplicate work. Do you
> also plan to send me a patch to fix all those warnings?
I think would prefer to enable the warnings that make sense
individually, -Wextra includes lots if crap like "%s expects
type char *, but argument is void *" or signedness warnings
that are compiler-detectable irrelevant 50% of the time.
OTOH a lot of the warnings in the current -git version indicate
that the code really needs more love, like missing return values
etc, so it seems we really want *some* of the new warnings.
next prev parent reply other threads:[~2008-07-23 14:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 11:33 [ULOGD2 PATCH 0/4] Misc cleaning Eric Leblond
2008-07-23 13:00 ` Pablo Neira Ayuso
2008-07-23 14:25 ` Pablo Neira Ayuso
2008-07-23 14:43 ` Patrick McHardy [this message]
2008-07-23 16:27 ` Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 0/11] Big warning hunting Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 01/11] Fix some simple warnings Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 02/11] Cleanly stop SYSLOG module Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 03/11] Suppress unused parameter in ipulog_read Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 04/11] Fix warning related to signed unsigned comparison Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 05/11] Suppress some warnings in format string usage Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 06/11] Fix warning about lack of parenthesis Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 07/11] Fix warning about integer format Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 08/11] Suppress twice defined key Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 09/11] Fix some initialisation Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 10/11] Make gcc happy Eric Leblond
2008-07-27 13:51 ` [ULOGD2 PATCH 11/11] Add option to CFLAGS to avoid useless warning Eric Leblond
2008-07-31 9:49 ` Pablo Neira Ayuso
2008-07-31 10:09 ` Patrick McHardy
2008-07-31 13:50 ` [ULOGD2 PATCH] Use attribute to avoid warning about unused parameter Eric Leblond
2008-07-31 14:46 ` Pablo Neira Ayuso
2008-07-31 15:11 ` Eric Leblond
2008-08-01 8:34 ` [ULOGD2 PATCH 11/11] Add option to CFLAGS to avoid useless warning Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488743AC.4040909@trash.net \
--to=kaber@trash.net \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox