From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@inl.fr>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [ULOGD2 PATCH 1/2] Add hardware address parsing to MAC2STR.
Date: Tue, 29 Jul 2008 12:18:09 +0200 [thread overview]
Message-ID: <488EEE61.5090503@netfilter.org> (raw)
In-Reply-To: <1217087028-1136-2-git-send-email-eric@inl.fr>
Eric Leblond wrote:
> This patch modifies the MAC2STR plugin to be able convert hardware
> address related fields to string:
> * raw.mac -> mac.str
> * raw.mac.saddr -> mac.saddr.str
> It is able to parse ethernet header. For ethernet
> we have the following conversion:
> * raw.mac ->
> * mac.saddr.str
> * mac.daddr.str
> * oob.protocol
> Output modules need to have raw.type. In case, ethernet is detected, this
> field is set to ethernet and sent to output by the module.
I have applied this patch. However, I have noticed that this patch still
does probing based on the header and field sizes for the ULOG case.
Since we now have the full link layer header via NFLOG (>= 2.6.27) and
ULOG is deprecated, I still don't quite understand why we should put any
effort on this. Actually, I may cook a patch to remove such probing.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
next prev parent reply other threads:[~2008-07-29 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 21:20 [ULOGD2 PATCH 2/4] Add parsing module for raw.mac Eric Leblond
2008-07-24 7:10 ` Pablo Neira Ayuso
2008-07-24 7:37 ` Eric Leblond
2008-07-24 17:16 ` Eric Leblond
2008-07-26 15:43 ` [ULOGD2 PATCH 0/2] MAC2STR rework Eric Leblond
2008-07-26 15:43 ` [ULOGD2 PATCH 1/2] Add hardware address parsing to MAC2STR Eric Leblond
2008-07-29 10:18 ` Pablo Neira Ayuso [this message]
2008-07-26 15:43 ` [ULOGD2 PATCH 2/2] Rename MAC2STR to HWHDR Eric Leblond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488EEE61.5090503@netfilter.org \
--to=pablo@netfilter.org \
--cc=eric@inl.fr \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox