Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: kaber@trash.net,
	Netfilter Developer Mailing List
	<netfilter-devel@vger.kernel.org>
Subject: Re: src: remove dependency on libiptc headers
Date: Mon, 04 Aug 2008 16:35:35 +0200	[thread overview]
Message-ID: <489713B7.10909@netfilter.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0808021220320.12119@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Saturday 2008-08-02 07:52, Pablo Neira Ayuso wrote:
>>>>  
> #define XTABLES_VERSION "@PACKAGE_VERSION@"                                     
>>>>  #define XTABLES_API_VERSION(x,y,z)    (0x10000*(x) + 0x100*(y) + z)
>>>>  
>>>> -	xt_chainlabel name;
>>>> +	const char *name;
>>>>  
>>> This is breaking the ABI. You're replacing at field of 32 bytes by one
>>> of 4 bytes.
> 
> The API actually remains the same, due to the nature of char[]
> decaying into char* (and .name is also only used in the registrator);
> the ABI (indicated by XTABLES_VERSION) changes yes, and that is fine
> because we moved from 1.4.1 to 1.4.2-rc1.

Sure, but say that someone uses whatever iproute2 version <=
iproute2-2.6.26 - which does not check for any ABI version numbering
AFAICS - and then it compiles whatever >= 1.4.2-rc1 by hand, then
jamal's ipt thing will not work as they use different ABIs.

I'm not talking on how to solve future interdependecy problems - which
you seems to have it done by exporting xtables as library - but the
problems that the size change of .name will trigger for some time.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

  reply	other threads:[~2008-08-05  0:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 13:04 src: remove dependency on libiptc headers Jan Engelhardt
2008-08-02 11:28 ` Pablo Neira Ayuso
2008-08-02 11:52   ` Pablo Neira Ayuso
2008-08-02 16:24     ` Jan Engelhardt
2008-08-04 14:35       ` Pablo Neira Ayuso [this message]
2008-08-04 23:44         ` Jan Engelhardt
2008-08-05  6:58           ` Pablo Neira Ayuso
2008-08-06  9:50             ` Patrick McHardy
2008-08-04 10:48 ` Patrick McHardy
  -- strict thread matches above, loose matches on Subject: below --
2008-07-30 13:19 Jan Engelhardt
2008-07-30 13:45 ` Patrick McHardy
2008-07-30 13:51   ` Jan Engelhardt
2008-07-30 14:08     ` Patrick McHardy
2008-07-31  7:02       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489713B7.10909@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox